Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Mapping type to match new mypy - #834

Merged
nolar merged 2 commits into
nolar:mainfrom
sobolevn:patch-1
Sep 21, 2021
Merged

Update Mapping type to match new mypy#834
nolar merged 2 commits into
nolar:mainfrom
sobolevn:patch-1

Conversation

@sobolevn

Copy link
Copy Markdown
Contributor

Hi!

I am working on a new feature in mypy and it identified a problem in your code.
Mapping[str, object] cannot be unpacked into priority: int = 0, lifetime: int = 60, lastseen: Optional[str] = None,, but Mapping[str, Any] can be.

Link: python/mypy#11151

@sobolevn
sobolevn requested a review from nolar as a code owner September 20, 2021 19:01
@nolar
nolar enabled auto-merge September 20, 2021 20:53
@nolar

nolar commented Sep 20, 2021

Copy link
Copy Markdown
Owner

Thanks for doing such checks pro-actively (it is an interesting idea!) and for sending this PR.

Please ignore the errors with DeprecationWarning: The loop argument is deprecated … — I am fixing them right now in a separate PR (#828). I will merge this PR as soon as I fix those asyncio issues (maybe a rebase will be needed).

@nolar
nolar merged commit fe56b56 into nolar:main Sep 21, 2021
@sobolevn

Copy link
Copy Markdown
Contributor Author

Thanks a lot for the quick fix! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants