Now *CustomType and **CustomType arguments are properly checked - #11151
Merged
Conversation
**CustomType argument is properly checked*CustomType and **CustomType argument is properly checked
*CustomType and **CustomType argument is properly checked*CustomType and **CustomType arguments are properly checked
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 20, 2021
This comment has been minimized.
This comment has been minimized.
JukkaL
reviewed
Sep 24, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Nice, this was a pretty bad gap in type checking. Left a few comments (not a full review).
Member
Author
|
Ok, I am adding #11138 support, it will require a couple of hours. |
Member
Author
|
@hauntsaninja any ideas why |
Collaborator
|
Just pushed a fix... @msullivan 's hack for edgedb in mypy_primer ended up breaking |
Member
Author
|
@hauntsaninja thank you! 🚀 |
Member
Author
|
@JukkaL @hauntsaninja is there anything else I can do to get this merged? Today we got another bugreport about this: #11375 |
hauntsaninja
approved these changes
Oct 31, 2021
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this is great!
Wish it was nicer to get the mapping and iterable types
Collaborator
|
This PR fixed an issue in an internal repo that I just encountered when testing the 0.920 release |
Member
Author
|
Awesome! 🎉 |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thing about this patch is that
ArgTypeExpanderneededmapping_typeanditerable_typefor checking*and**arguments.But, this context was not provided.
I've also fixed a bunch of related
TODOitems.Closes #11144
Closes #11138
Closes #11375