-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
DOC: Add missing documentation for top-level functions #10106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would like to work on this as my first contribution, is it open? :) |
It seems the basic classes are documented, no? |
|
* DOC: add docstring for np.float16 (see #10106) * DOC: add docstrings for uint8, uint16, uint32, uint64 (see #10106) * DOC: make numeric types' docstrings char codes formatting consistent * DOC: Adding documentation to C/Python compatible names of scalar types * DOC: Adding platform-dependent aliases to scalar type docstrings * DOC: Fix typos and minor issues in scalar type docstrings * DOC: Add hard-coded aliases to scalar type docstrings * DOC: Fix platform-dependent aliases in doc string of scalar types * DOC: Fix indentation of numeric types' docstring * TST: Add test checking for platform-dependent generation of numeric type docstrings * TST: Fix docstring test failures when PYTHONOPTIMIZE/Py_OptimizeFlag > 1 * TST: Moving check of PYTHONOPTIMIZE for test_numerictypes.py::TestDocStrings into pytest.mark.skip decorator * DOC: Cleanup code for adding docstrings to numeric types and mention canonical type name * DOC: Cleaning up access of numeric type objects and character codes in dynamic docstring generation * DOC: Prepend 'np.' to numeric type docstrings * MAINT: Remove dead code, rename function * DOC: Cleaning up numeric_type_aliases in core/_add_newdocs.py * DOC: Fixing dynamic aliases in docstrings for complex scalar types * DOC: Removing docstrings for complex scalar types in numpy/core/src/multiarray/scalartypes.c.src, as they are now set in numpy/core/_add_newdocs.py * DOC: Merging lists of different dynamic aliases into one, and prepending 'np.' to fixed aliases * DOC: Adding scalar type docstring improvements to release notes * DOC: Tweak release notes
Thanks @YannickJadoul for knocking out a whole bunch of these! |
DOC: add a docstring for the function 'compare_chararrays' (See #10106)
Hi, can I work on the documentation for the unticked functions? Or have they been done already? |
@smellslikekeenspirit you can check by help(), if it returns None then the documentation is missing. If you find they are not missing, please let us know so we can mark them. |
Hello. Potential first time contributor here. I re-ran the script up top and got:
I'm struggling to understand what needs to be accomplished. Any guidance would be appreciated. Looking at np.datetime64 below. I see that np.datetime64.doc is None. But when checking help(), I see output for that. Can someone explain what the current help is returning, and what it is lacking?
|
Hi @engineerlisa, welcome! I would suggest to start with
|
Note that |
Hmm, that PR looks a little complicated. @engineerlisa please have a look if that PR makes sense to you ( @eric-wieser I removed the "good first issue" label, the left overs aren't a matter of writing docs anymore. I think a maintainer should finish the last bits here. |
Thank you for getting back to me. I understand some parts of that PR. Based on your removing the tag, I'm going to find another candidate for my first contribution. |
Just two left here
Both of these should be easy to document, so I'm going to add back the "good first issue" label |
Hey, I'm a first time contributor and I would like to take up the remaining two functions if they are still open. Any guidance would be appreciated. Thanks! |
Hi @kumudlakara. You should start with the contributor guide for an overview, especially the section on documentation and then the development workflow for the details. We don't assign issues, so be sure to mark your PR with |
Alright, Thank you @mattip . |
Hi, I'm a first time contributor and I would like to work on this issue if they are still open. Any guidance would be appreciated. Thanks! |
Hi @Radhika14soni and welcome. I commented above on how to get familiar with the process. Since |
@mattip Hello I'd like to work on it. Am I supposed to make changes in _add_newdocs.py? |
Since this is a pure-python class, the change would be to add a docstring to the class definition like for the other exception classes in that file. |
Is there any works pending on this issue that I can take ? I am new to numpy contribution and looking for anything to work on |
From the comments above it looks like this issue is taken care of, @mugunthanramesh . But feel free to browse other Documentation-related issues and ping me if you need help getting started. Cheers! |
Closing then. Please open a new issue if there are still missing docstrings, this one is too difficult to navigate. |
Uh oh!
There was an error while loading. Please reload this page.
Exposed are:
<function <lambda> at 0x0000026322836C80>
(np.deprecate_with_doc
)MAINT: Remove np.pkgload, which seems to be unusable anyway #11703<class 'numpy._import_tools.PackageLoader'>
(np.PackageLoader
)<class 'numpy.core._internal.TooHardError'>
(np.TooHardError
) - DOC: adding docstring to TooHardError class #21471<function _numpy_tester at 0x000002632285C268>
(np._numpy_tester
)<built-in function compare_chararrays>
(np.compare_chararrays
) - DOC: add a docstring for the function 'compare_chararrays' (See #10106) #12338<built-in function datetime_as_string>
(np.datetime_as_string
) - DOC: Add documentation for datetime_as_string #10107<built-in function datetime_data>
(np.datetime_data
) - DOC: Add documentation for datetime_data #10108<built-in function int_asbuffer>
(np.int_asbuffer
) - Remove int_asbuffer #12425<built-in function nested_iters>
(np.nested_iters
) - DOC: nditer.nested_iters are not documented #10009<function show at 0x00000263225800D0>
(np.show_config
) -show_config()
has no docstring and is not in the online docs. #9258<class 'numpy.bytes_'>
(np.bytes0
,np.string_
,np.bytes_
)<class 'numpy.character'>
(np.character
) - DOC: Add docstrings for abstract types in scalar type hierarchy #12027<class 'numpy.complexfloating'>
(np.complexfloating
) - DOC: Add docstrings for abstract types in scalar type hierarchy #12027<class 'numpy.datetime64'>
(np.datetime64
) - datetime64("now") is undocumented #10003, datetime64 not present in intersphinx inventory #10039, ...<class 'numpy.flexible'>
(np.flexible
) - DOC: Add docstrings for abstract types in scalar type hierarchy #12027<class 'numpy.float16'>
(np.half
,np.float16
) - DOC: add docstrings for numeric types #11858<class 'numpy.float64'>
(np.longdouble
,np.longfloat
) - DOC: add docstrings for numeric types #11858<class 'numpy.floating'>
(np.floating
) - DOC: Add docstrings for abstract types in scalar type hierarchy #12027<class 'numpy.inexact'>
(np.inexact
) - DOC: Add docstrings for abstract types in scalar type hierarchy #12027<class 'numpy.int32'>
(np.intc
) - DOC: add docstrings for numeric types #11858<class 'numpy.integer'>
(np.integer
) - DOC: Add docstrings for abstract types in scalar type hierarchy #12027<class 'numpy.number'>
(np.number
) - DOC: Add docstrings for abstract types in scalar type hierarchy #12027<class 'numpy.signedinteger'>
(np.signedinteger
) - DOC: Add docstrings for abstract types in scalar type hierarchy #12027<class 'numpy.str_'>
(np.str0
,np.unicode_
,np.str_
)<class 'numpy.timedelta64'>
(np.timedelta64
)<class 'numpy.uint16'>
(np.uint16
,np.ushort
) - DOC: add docstrings for numeric types #11858<class 'numpy.uint32'>
(np.uintc
) - DOC: add docstrings for numeric types #11858<class 'numpy.uint32'>
(np.uint
,np.uint32
) - DOC: add docstrings for numeric types #11858<class 'numpy.uint64'>
(np.uint64
,np.uintp
,np.ulonglong
,np.uint0
) - DOC: add docstrings for numeric types #11858<class 'numpy.uint8'>
(np.uint8
,np.ubyte
) - DOC: add docstrings for numeric types #11858<class 'numpy.unsignedinteger'>
(np.unsignedinteger
) - DOC: Add docstrings for abstract types in scalar type hierarchy #12027<class 'numpy.void'>
(np.void0
,np.void
)Steps to document many of these:
np.core.multiarray.uint16
toin the appropriate placenumpy/add_newdocs.py
:/doc/source/reference/routines.*.rst
- look at existing files to see howScript to generate the above
The text was updated successfully, but these errors were encountered: