MAINT: Remove np.pkgload, which seems to be unusable anyway #11703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
Aug 10, 2018
| """ | ||
| # 2014-10-29, 1.10 | ||
| warnings.warn('pkgload and PackageLoader are obsolete ' | ||
| 'and will be removed in a future version of numpy', |
There was a problem hiding this comment.
Didn't even spot this. > 3ish years seems like plenty of time to wait, especially since it seems we broke it anyway
|
Needs a release note, otherwise LGTM. |
Attempts to use this on either cpython27 or cpython35, in either a shell or a script, gives:
NameError: name '__path__' is not defined
Perhaps I'm calling it wrong, but it might just be broken.
ae16dac to
85cf4ef
Compare
|
Updated |
|
Thanks Eric. |
This was referenced Sep 19, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to use this on either cpython27 or cpython35, in either a shell or a script, gives: