-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
DOC: Inaccessible contrast for a:visited links in admonitions #26058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is fixed in the most recent versions of the theme (with the updated colour palette). So once the pin on 0.13 is removed this should no longer be a problem. It's also related to #25927 |
The pin is here. Should we pin to a newer version? Which one?
|
Fixes inaccessible contrast for a:visited links in admonitions. Fixes numpy#26058.
Let's go for the newest version, 0.15.2. Please see PR #26125. |
Bringing this issue also to this conversation as it would be good to ensure both the colour and font issues mentioned in #25927 are addressed. |
Fixes inaccessible contrast for a:visited links in admonitions. Fixes numpy#26058.
Uh oh!
There was an error while loading. Please reload this page.
Issue with current documentation:
The contrast of purple on the dark background is low: it's ratio is 1.51, below the WCAG AA level of 4.5:
This comes from
basic.css
, which I think is from Sphinx:If I disable the rule, it looks like this, with a good ratio of 5.37:
The docs use PyData Sphinx Theme 0.13.3, but I can't reproduce the problem with these links (and inspecting the elements to edit in a link):
The text was updated successfully, but these errors were encountered: