-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
BUG: Unexpected breaking change in np.reshape
on v2.1.0
#27256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
9 tasks
I think this was simply missed during the refactor and all that's needed is to move @jonathanberthias if you're interested, you can set up testing against the NumPy nightly wheels to help us catch these changes before we do releases. |
@ngoldbaum Sure! |
mtsokol
added a commit
to mtsokol/numpy
that referenced
this issue
Aug 21, 2024
mtsokol
added a commit
to mtsokol/numpy
that referenced
this issue
Aug 21, 2024
charris
pushed a commit
to charris/numpy
that referenced
this issue
Aug 24, 2024
ArvidJB
pushed a commit
to ArvidJB/numpy
that referenced
this issue
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Describe the issue:
The API for
np.reshape
was modified to accept all the arguments from the Array API in #26292, but there was a side effect which was not reported in the release notes of v2.1.0.The issue is that the
order
argument could previously be passed by position, but now it is keyword-only.Reproduce the code example:
Error message:
Python and NumPy Versions:
2.1.0
3.12.4 (main, Jun 6 2024, 18:26:44) [GCC 11.4.0]
Runtime Environment:
No response
Context for the issue:
I don't think it's a bad thing to have to specify the
order
by keyword, but I think in this case the change was not intended as:order
by position is valid, but not at runtime.The text was updated successfully, but these errors were encountered: