Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: Fix #27256 and #27257 #27262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

BUG: Fix #27256 and #27257 #27262

merged 1 commit into from
Aug 23, 2024

Conversation

mtsokol
Copy link
Member

@mtsokol mtsokol commented Aug 21, 2024 •
edited
Loading

This PR addresses #27256 and #27257:

  • Re-allow to pass order as a positional or keyword argument in np.reshape.
  • Update np.fix docstring to include "no-casting to a floating data type" change.

To be backported to 2.1.x.

@mtsokol mtsokol added this to the 2.1.1 release milestone Aug 21, 2024
@mtsokol mtsokol self-assigned this Aug 21, 2024
This was linked to issues Aug 21, 2024
BUG: Unexpected breaking change in np.reshape on v2.1.0 #27256
Closed
DOC: Invalid docstring for numpy.fix (?) #27257
Closed
@jonathanberthias jonathanberthias mentioned this pull request Aug 21, 2024
Merged
9 tasks
@WarrenWeckesser
Copy link
Member

The docstring of ceil also needs a fix; currently the "Returns" section describes the return value as "The ceiling of each element in x, with float dtype.":

numpy/numpy/_core/code_generators/ufunc_docstrings.py

Lines 795 to 799 in dc5f21e

Returns
-------
y : ndarray or scalar
The ceiling of each element in `x`, with `float` dtype.
$OUT_SCALAR_1

jorenham
jorenham reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be wise to also update the signature in the stubs
https://github.com/numpy/numpy/blob/main/numpy/_core/fromnumeric.pyi#L94-L107

@mtsokol
Copy link
Member Author

mtsokol commented Aug 21, 2024

The docstring of ceil also needs a fix; currently the "Returns" section describes the return value as "The ceiling of each element in x, with float dtype.":

Done!

It might be wise to also update the signature in the stubs https://github.com/numpy/numpy/blob/main/numpy/_core/fromnumeric.pyi#L94-L107

Also done!

@ev-br ev-br mentioned this pull request Aug 23, 2024
Merged
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Aug 23, 2024
@charris charris merged commit ae926d7 into numpy:main Aug 23, 2024
66 checks passed
@charris
Copy link
Member

charris commented Aug 23, 2024

Thanks @mtsokol .

@mtsokol mtsokol deleted the bug-27256-27257 branch August 23, 2024 17:21
@charris charris mentioned this pull request Aug 24, 2024
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenham jorenham jorenham left review comments

Assignees

@mtsokol mtsokol

Labels
00 - Bug 04 - Documentation
Projects
None yet
Milestone
2.1.1 release
Development

Successfully merging this pull request may close these issues.

DOC: Invalid docstring for numpy.fix (?) BUG: Unexpected breaking change in np.reshape on v2.1.0
4 participants
@mtsokol @WarrenWeckesser @charris @jorenham