BUG: Fixes einsum broadcasting bug when optimize=True #11218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Jun 1, 2018
numpy/core/tests/test_einsum.py
Outdated
| p = np.ones((1, 5)) | ||
| q = np.ones((5, 5)) | ||
|
|
||
| # a blas-compatible contraction broadcasting case which was failing |
There was a problem hiding this comment.
There is trailing whitespace on these two lines.
charris
reviewed
Jun 1, 2018
numpy/core/tests/test_einsum.py
Outdated
| assert_array_equal(np.einsum("i, i", x, y, optimize=True), 0.) | ||
|
|
||
| # all-ones array was bypassing bug (ticket #10930) | ||
| p = np.ones((1, 5)) / 2 |
There was a problem hiding this comment.
Curious why you wanted floats here?
charris
approved these changes
Jun 1, 2018
|
LGTM, I'll wait on @dgasmith . |
dgasmith
approved these changes
Jun 1, 2018
numpy/core/tests/test_einsum.py
Outdated
| q = np.ones((5, 5)) | ||
| # a blas-compatible contraction broadcasting case which was failing | ||
| # for optimize=True (ticket #10930) | ||
| x = np.array([0., 0.]) |
There was a problem hiding this comment.
Can we use array of say 5s just incase we hit some sort of weird bug.
There was a problem hiding this comment.
Sure, I'll have to wait until I'm home from work.
|
@dgasmith this should be good to go now (updated the test as you requested) |
|
Thanks @rsokl . For next time, might take a look at the howto for commit messages at |
|
Ah thanks for pointing me to that. I wasn't aware of it. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10930.