BUG/ENH: Einsum optimization path updates and bug fixes. #11345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmgray
reviewed
Jun 18, 2018
numpy/core/einsumfunc.py
Outdated
|
|
||
| # Initially iterate overa ll pairs |
|
Needs a typo fix and an update for the conflicting files |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jul 3, 2018
* Minor tweaks to the optimal path based on opt_einsum * Updates greedy path to current opt_einsum tech * Reworks einsum broadcasting vs dot tech and can_dot logic * MAINT: Fix typo in comment. * BUG: Fix bad merge fixup.
|
Thanks for getting this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs einsum path optimization tech between
numpyandopt_einsum. In particular, thegreedypath has received many enhancements by @jcmgray. A full list of issues fixed in this PR are:greedypath. Fixes einsum_path greedy optimize ignores memory limit in some cases #11210.can_dotfunctionality that previous missed an edge case (part of einsum optimization failure and inconsistency #11308).