MAINT: Warn if _add_newdocs.py is used to add docstrings to pure-python objects
#13935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
Jul 8, 2019
_add_newdocs.py to add docstrings to pure-python objects_add_newdocs.py to add docstrings to pure-python objects
|
Will rebase this on gh-13946 |
aa81973 to
f1a974c
Compare
|
Rebased, pushed to the wrong branch by accident so this never updated |
_add_newdocs.py to add docstrings to pure-python objects_add_newdocs.py is used to add docstrings to pure-python objects
charris
reviewed
Jul 14, 2019
|
|
||
|
|
||
| def _add_docstring(obj, doc, warn_on_python): | ||
| if warn_on_python and not _needs_add_docstring(obj): |
There was a problem hiding this comment.
The tests are complaining about the stack level of the warning.
…-python objects This caught the duplication of docstrings between multiarray.py and _add_newdocs
f1a974c to
d14632c
Compare
|
Thanks @eric-wieser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the maintenance part of #13876