DOC: Add a numpy-doc docstring to add_newdoc #13946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht size Previously this would silently ignore extra items
|
Is it worth mentioning this breaks the assumption that all slots will be filled before |
|
@mattip: Sure, that might be worth a mention. Want to add the note yourself, since I think you remember the details of that best (either as an extra commit in this PR or a follow-up) |
3ceefa5 to
45c4a8d
Compare
eric-wieser
commented
Jul 10, 2019
| C-API best-practices, by: | ||
|
|
||
| - modifying a `PyTypeObject` after calling `PyType_Ready` | ||
| - calling `Py_INCREF` on the str and losing the reference, so the str |
There was a problem hiding this comment.
Fixed the typo, and changed to PyType_Ready too
mattip
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether or not we decide this is public API, @charris wanted to see a standard-style docstring, which I think is a pretty fair request.