Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: test, fix for c++ compilation #15194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 30, 2019
Merged

BUG: test, fix for c++ compilation #15194

merged 3 commits into from
Dec 30, 2019

Conversation

mattip
Copy link
Member

@mattip mattip commented Dec 29, 2019

xref scikit-image/scikit-image#4369

The blanket addition of -std=c99 to the compiler flags broke compilation for c++ compilers. Now tested and fixed.

@mattip
Copy link
Member Author

mattip commented Dec 29, 2019

Worth a release note?

@mattip mattip mentioned this pull request Dec 29, 2019
Closed
eric-wieser
eric-wieser reviewed Dec 29, 2019
View reviewed changes
@jni
Copy link
Contributor

jni commented Dec 30, 2019

@mattip thank you for picking this up so quickly! 🙏

eric-wieser
eric-wieser approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A docstring explaining why the test asserts what it does might be nice, but feel free to merge as is.

@mattip
Copy link
Member Author

mattip commented Dec 30, 2019

feel free to merge as is.

Although not explicitly stated, I prefer a policy that someone other than the author merge a PR, even if it has been approved.

@eric-wieser
Copy link
Member

Although not explicitly stated

If you feel strongly about this, maybe bring it up in the next community call - I wouldn't be opposed to a wording change in those docs to at least discourage self-merges.

eric-wieser
eric-wieser reviewed Dec 30, 2019
View reviewed changes
@eric-wieser eric-wieser merged commit 63ef78b into numpy:master Dec 30, 2019
@charris charris added this to the 1.18.1 release. milestone Jan 1, 2020
charris pushed a commit to charris/numpy that referenced this pull request Jan 2, 2020
@mattip @charris
BUG: remove -std=c99 for c++ compilation (numpy#15194)
ddf292d 
This flag is only legal for C compilers
@charris charris mentioned this pull request Jan 2, 2020
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jan 2, 2020
@charris charris removed this from the 1.18.1 release. milestone Jan 2, 2020
charris added a commit that referenced this pull request Jan 2, 2020
@charris
Merge pull request #15221 from charris/backport-15194
a06e732 
BUG: remove -std=c99 for c++ compilation (#15194)
@prisae prisae mentioned this pull request Jan 3, 2020
Closed
@pv
Copy link
Member

pv commented Jan 4, 2020

FYI, -std=c99 also turns on different floating point excess precision handling on 387, and that breaks stuff: scipy/scipy#11270 (comment)

@charris
Copy link
Member

charris commented Jan 4, 2020

I will put out a 1.18.1 tomorrow with the fix.

@pv
Copy link
Member

pv commented Jan 4, 2020 •
edited
Loading

I think it might be better if the -std=c99 flag was not added for C code either, given that it implies semantic changes for downstream projects' code. Maybe the intent was to add the option only for Numpy (in which case it would be added in Numpy's setup.py)?

@mattip mattip mentioned this pull request Jan 4, 2020
Merged
@charris charris mentioned this pull request Jan 5, 2020
Merged
@mattip mattip deleted the cxx-compile branch November 2, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
00 - Bug component: build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattip @jni @eric-wieser @pv @charris