Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAINT: only add --std=c99 where needed #15245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2020
Merged

MAINT: only add --std=c99 where needed #15245

merged 2 commits into from
Jan 5, 2020

Conversation

charris
Copy link
Member

@charris charris commented Jan 5, 2020 •
edited
Loading

Backport of #15238.

Revert gh-15194, redo gh-14471

We really only need --std=c99 for pocketfft compilation, so do not add it unilaterally. Add the flag via setup.py. As pointed out in scipy/scipy#11270, this also turns on different floating point excess precision handling on 387 FPU.

@charris charris added component: build 08 - Backport Used to tag backport PRs labels Jan 5, 2020
@charris charris added this to the 1.18.1 release. milestone Jan 5, 2020
@charris charris merged commit 40addab into numpy:maintenance/1.18.x Jan 5, 2020
@charris charris deleted the backport-15238 branch January 5, 2020 21:37
@sethtroisi
Copy link
Contributor

Backport of #15238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
08 - Backport Used to tag backport PRs component: build
Projects
None yet
Milestone
1.18.1 release.
Development

Successfully merging this pull request may close these issues.
3 participants
@charris @sethtroisi @mattip