ENH: Extending CPU feature detection framework to support IBM Z SIMD #20552
Conversation
|
@seiko2plus Sayed, what's your progress? |
There was a problem hiding this comment.
Hello @pradghos, along with the following suggestions we still need to add to test runtime detection similar to:
numpy/numpy/core/tests/test_cpu_features.py
Lines 140 to 147 in 93301a5
we have several SIMD kernels now written by universal intrinsics, and more coming. I was working on s390x implementation but I pause it in favor of replacing/implementing more kernels to universal intrinsics first. |
|
Hi @seiko2plus, I have incorporated the review comments now, Thank you very much for the review ! |
We would like to extend CPU feature detection infrastructure for IBM Z CPU features. Eventually It will help to add and enable Z specific SIMD builtins and instructions. As part of the PR, we have extended ccompiler_opt.py, npy_cpu_features.c.src, npy_cpu_features.h, other files for Z CPU feature detection and added test files for VX/VXE/VXE2 in distutils/checks.
d83538f to
9cedd78
Compare
|
Thanks @pradghos, @seiko2plus |
|
Excellent thank you @pradghos, @seiko2plus and @mattip |
| x86_gcc="-msse -msse2", x86_icc="-msse -msse2", | ||
| x86_iccw="/arch:SSE2", | ||
| x86_msvc="/arch:SSE2" if self.march() == "x86" else "", | ||
| ppc64_gcc= "-mcpu=power8", | ||
| ppc64_clang="-maltivec -mvsx -mpower8-vector", | ||
| armhf_gcc="-mfpu=neon-fp16 -mfp16-format=ieee", | ||
| aarch64="" | ||
| aarch64="", | ||
| s390="-mzvector -march=arch12" |
|
Hi-five on merging your first pull request to NumPy, @pradghos! We hope you stick around! Your choices aren’t limited to programming – you can review pull requests, help us stay on top of new and old issues, develop educational material, work on our website, add or improve graphic design, create marketing materials, translate website content, write grant proposals, and help with other fundraising initiatives. For more info, check out: https://numpy.org/contribute/. |
We would like to extend CPU feature detection infrastructure for IBM Z CPU features.
Eventually It will help to add and enable Z specific SIMD builtins and instructions.
As part of the PR, we have extended
ccompiler_opt.py,npy_cpu_features.c.src,npy_cpu_features.h, other files for Z CPU feature detection and added test files forVX/VXE/VXE2indistutils/checks.cc @edelsohn @Andreas-Krebbel @potula-chandra @ajaypvictor