-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
BLD: add libquadmath to licences and other tweaks #24753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Where are you seeing that? https://github.com/gcc-mirror/gcc/blob/master/libquadmath/COPYING.LIB looks like a standard LGPL license.
Correct, we used to bundle |
I took the libquadmath license from the appropriate section in my (debian) /usr/share/doc/gcc-12-base/copyright. Note that that file mistakenly lists the wrong license for Edit: here is the debian bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1052314 |
Diving into the actual code will show that each file has a license, most are like this
|
I don't think we need to include very granular per-file copyright statements. The upstream GCC license I linked is standard LGPL as far as I can tell.
That is perfectly normal, but not really relevant imho. We also have public-domain code in NumPy and SciPy, and since that's BSD-3 compatible we make no attempt to list per-file differences in our own |
libgfortan, as the LICENSE text in NumPy currently indicates, is released under gpl v3 with an exception. libquadmath, as you point out, is released under lgpl 2.1 and some files are specifically LGPL2.0 or later. So I can simplify the PR to use LGPL2.1 for libquadmath. A single file has a "Public Domain" license, I guess we can put that in the "more permissive" category and not list it separately. |
…] [skip azp] [skip actions]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Matti. A few minor comments, and one that looks critical: the path to the bundled libraries for the Windows wheels is indeed numpy.libs\
now and not .libs
, however the _distributor_init.py
still uses .libs
. I don't quite understand how this isn't broken. If you have a Windows machine at hand, can you check?
A bit of magic that came in with the overly-large #23838 and I didn't realize at the time. We now use delvewheel to repair the wheel, which adds this snippet to the beginning of
so actually, we don't need the |
The |
I fixed the review comments and changed all the specifiers to be spdx compliant |
We do on Python 3.9: conda/conda#10897 (comment). We should fix |
For python3.9 or conda, delvewheel does it differently:
Edit: Note I agree we should make CI more like |
I cherry-picked the change from #24765 into this PR |
Closes #24764 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Matti! I'll squash-merge this for ease of backporting.
This is an uncertain backport due to the changes made during the testing cleanup. I'm tempted to just take all the changes into 1.26.x, but that requires some checking that nothing gets lost . 2.0.0 and 1.26.x do build the same wheels at this point. |
It looks like all changes are okay to backport here, except possibly the env var removal in |
Other improvements: - use SPDX short specifiers, fixes from review - only use `openblas_support.make_init()` in CI, fix paths - fix license concatenation for wheels we distribute Closes numpygh-24764
Other improvements: - use SPDX short specifiers, fixes from review - only use `openblas_support.make_init()` in CI, fix paths - fix license concatenation for wheels we distribute Closes numpygh-24764
BLD: add libquadmath to licences and other tweaks (#24753)
Other improvements: - use SPDX short specifiers, fixes from review - only use `openblas_support.make_init()` in CI, fix paths - fix license concatenation for wheels we distribute Closes numpygh-24764
As pointed out in MacPython/openblas-libs#114, we are bundling libquadmath which is licensed differently than the rest of the gcc runtimes. This PR
cc @rgommers for review?
I think this should be backported. While #24613 to use Accelerate for macos-arm64 was backported, I see the 1.26 wheels are still using OpenBLAS, so the license should not change.