MAINT: fix licence path win #24793
MAINT: fix licence path win #24793
Conversation
| @@ -880,7 +880,7 @@ Public License instead of this License. But first, please read | |||
| <http://www.gnu.org/philosophy/why-not-lgpl.html>. | |||
|
|
|||
| Name: libquadmath | |||
| Files: numpy\.libs\libopenb*.dll | |||
| Files: numpy.libs\libopenb*.dll | |||
There was a problem hiding this comment.
Are we statically linking a .dll? Or should it be .a for Windows? And we're sure it should be an OpenBLAS library name for quadmath instead of a quadmath-specific lib? Is it an indirect link to quadmath via OpenBLAS then?
There was a problem hiding this comment.
I guess that's what's in the wheel, although maybe the static linking line below this line is less clear to me via DLL.
There was a problem hiding this comment.
I think this is correct. The one file that is vendored is libopenblas64*.dll, and that DLL also contains statically linked libgcc and libquadmath.
| @@ -880,7 +880,7 @@ Public License instead of this License. But first, please read | |||
| <http://www.gnu.org/philosophy/why-not-lgpl.html>. | |||
|
|
|||
| Name: libquadmath | |||
| Files: numpy\.libs\libopenb*.dll | |||
| Files: numpy.libs\libopenb*.dll | |||
There was a problem hiding this comment.
I think this is correct. The one file that is vendored is libopenblas64*.dll, and that DLL also contains statically linked libgcc and libquadmath.
Yes, that is permitted. I looked at those details when reviewing gh-24753; there's no substantial difference in dynamic vs static linking. |
|
Thanks Andrew. |
|
just a comment: (windows) a statically linked and stripped libquadmath.dll doesn't include any libquadmath code. This can be easily proven with linker maps. |
|
@carlkl I don't understand the comment. The source code is still compiled into the resulting OpenBLAS dll. |
|
Or are you saying that the windows DLL does not actually use any of the libquad code, since it does not call any 128-bit float routines, so the linker will not pull in the code? |
|
Ahh, I found this discussion of libquadmath on an openblas-libs issue MacPython/openblas-libs#82 (comment). It would be nice to upstream that patch. |
|
I tested this last year or so with te help of linker maps. The symbol |
@charris, I think there's a mistake in the licence path on windows.
Also, is it permitted to statically link a LGPL libquadmath into the libopenblas that we bundle?