BLD: limit scipy-openblas32 wheel to 0.3.23.293.2 #25085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Matti. This looks good to me, just one more tweak needed to the 32-bit Azure job - that failure is real: The Cirrus CI is an unrelated crash, and it has something to do with picking up plain |
3aff268 to
eafe1d3
Compare
eafe1d3 to
20a970e
Compare
rgommers
approved these changes
Nov 13, 2023
charris
added a commit
to charris/numpy
that referenced
this pull request
Nov 19, 2023
Partial backport of numpy#25085.
charris
added a commit
to charris/numpy
that referenced
this pull request
Nov 19, 2023
Partial backport of numpy#25085.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working towards adding a scipy_ prefix to all the openblas symbol names in the scipy-openblas wheels. This will allow using both the scipy-openblas wheels and another OpenBLAS library together in scipy, for instance if using a scipy compiled with the "regular" OpenBLAS together with a numpy compiled with the OpenBLAS wheels.
In order to do an ordered transition, first this PR freezes the current version of scipy-openblas32/64 used in CI here. Then I will release new scipy-openblas32 wheels with an updated scipy-openblas.pc file, that will define a
-DBLAS_SYMBOL_PREFIX=scipy_compile-time directive. Then I will come back to here and submit a new PR that reverts this one, and makes sure the use ofBLAS_SYMBOL_PREFIXactually works.xref @scipy/scipy#19484
cc @rgommers