Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BLD, CI: revert pinning scipy-openblas #25151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

mattip
Copy link
Member

@mattip mattip commented Nov 15, 2023

Reverts #25085

The OpenBLAS builds now have a prefix scipy_, in addition to the ILP64 suffix 64_. The prefix is automatically used when meson detect scipy-openblas via the pkg-config script. That script also adds OPENBLAS_ILP64_NAMING_SCHEME so meson no longer need the use-ilp64=true argument.

@github-actions github-actions bot added the 36 - Build Build related PR label Nov 15, 2023
@mattip
Copy link
Member Author

mattip commented Nov 15, 2023

The prefix is added as of scipy-openblas 0.3.24.95.0. Because the magic happens in the pkg-config Cflags, which are part of the wheel, older versoin can still be used and will work. They will not have the prefix, so newer versions should be prefered in order to avoid symbol confusion when more than one CBLAS library is linked in (like when mixing a NumPy built with the scipy-openblas wheels together with a SciPy that is built using a different CBLAS library).

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Nov 15, 2023
@seberg
Copy link
Member

seberg commented Nov 15, 2023

LGTM, and I doubt there is a lot of complexity I am missing, thanks Matti.

If/when we would release wheels with this, they would need a version pin in principle to ensure that the user cannot have an older one already?
Although, if that is the case, I wonder if just janking old versions might also make sense.

@seberg seberg merged commit 51ee17b into numpy:main Nov 15, 2023
@seberg seberg removed the 09 - Backport-Candidate PRs tagged should be backported label Nov 15, 2023
@seberg
Copy link
Member

seberg commented Nov 15, 2023

Removing backport candidate, NumPy 1.26 doesn't include the scipy-openblas stuff.

@mattip
Copy link
Member Author

mattip commented Nov 15, 2023

If/when we would release wheels with this ...

The wheels will keep the old linking (i.e. not depending on the scipy-openblas wheels at runtime, only using them at build time and then shipping + RPATHing the shared objects) for the foreseeable future, since there are problems to express the metadata needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
36 - Build Build related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants