BUG: avoid negating unsigned integers in resize implementation #29230
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
reviewed
Jun 18, 2025
36d4da2 to
1652013
Compare
|
Looks good, thanks. (Another fix might be to call |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jun 19, 2025
…#29230) The negation of an unsigned int underflows and creates a large positive repeats, which leads to allocations failures and/or swapping.
charris
added a commit
that referenced
this pull request
Jun 19, 2025
BUG: avoid negating unsigned integers in resize implementation (#29230)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29225.
The negation of an unsigned int underflows and creates a large positive
repeats, which leads to allocations failures and/or swapping.