changed asscalar to pass through scalars #5126
Conversation
| return a.item() | ||
| try: | ||
| return a.item() | ||
| except AttributeError as e: |
There was a problem hiding this comment.
Just plain old except AttributeError: will work fine, you don't make any use of e.
|
Hmm, the function is documented to work with arrays of size 1, but not with scalars. It is not clear what we should do in the case of scalars, although your fix looks as good as any. The two commits should be squashed into one. |
|
I think it best to leave the function as is. One thing that could be done is check for array of size == 1 and raise a more informative error message, but the function is not used anywhere in numpy and not tested, so probably not very important. Straight use of The function has no test, so if you want to submit a PR with a test, that would be good. |
#4701