ENH: NpyIter: add a flag to handle read/write operand overlap #8026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, wow you figered out how to do it right, I guess :)! I want to stil read it carefullyonce, but I guess we can pretty much put this in and then the next step should be ufuncs. Goodbye |
| i = nditer([a, b], ['copy_if_overlap'], [['readonly'], ['readwrite']]) | ||
| assert_(not np.shares_memory(*i.operands)) | ||
|
|
||
| # Copy not needed, 2 ops, no overlap |
There was a problem hiding this comment.
Comment slightly off, overlap but identical.
|
OK, since its new API, just wrote a mail to the list (not that I expect much feedback). Might be good to add a release note (which would probably keep growing with more changes). |
Add a new NPY_ITER_COPY_IF_OVERLAP iterator flag to NpyIter, which instructs it to check if read operands overlap with write operands in memory, and make temporary copies to eliminate detected overlap. Thanks to Sebastian Berg.
3302254 to
a063040
Compare
2 tasks
|
Closing, maybe better to discuss as a part of gh-8043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new NPY_ITER_COPY_IF_OVERLAP iterator flag to NpyIter, which
instructs it to check if read operands overlap with write operands in
memory, and make temporary copies to eliminate detected overlap.
Thanks to @seberg (whose code it mostly is).
The idea here is to approach gh-6272 in small steps --- I've been looking at what changes are needed to deal with it everywhere, and I think it will go better if done in small side-effect free pieces. (The rest here).