-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
DOC: show_config documentation #9312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ore 'generated/' again.
I think that choice is fine. However you now have duplicated the docstring content because of the difficulty of including it with The linkcode not resolving is an issue that's probably solvable, but I'm not too bothered right now - quite a bit of work for a very minor thing. |
I removed the duplication by putting the documentation in an |
Exclude patterns for .rst files.
This works and docs look good to me. I have the feeling that this is going to break something though - that file reading doesn't look very robust. It's hard to predict how; for example packaging scripts could be stripping off I've seen enough versions now that I've gotten a bit confused - could you remind me why the obvious solution (have the docstring inside |
The issue was that |
Isn't this also true of any C function though? |
I did stumble upon the I'll give these a go today. |
I don't think "Sphinx doesn't know about them prior to building the project" is a good argument, as I think this is already true in many other places. |
@eric-wieser as I am new to the project's source code, I would appreciate it if you could tell me where to look for something similar in the source, if you can think of such a place. |
I'm saying that the suggestion to "have the docstring inside generate_config_py" seems correct to me, as suggested by @rgommers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a consensus that the way to do this is in generate_config_py
.
This pull request is superseded by #15429, so closing. |
Continuing from #9275, fixing #9258
@rgommers @charris
I ended up going with your original suggestion and put the documentation in the packaging (distutils) section.
Final question:
Notice that because I have Numpy built on my machine,
linkcode_resolve
finds the source forshow_config
in__config__.py
and produces a URL, which it then tries to follow on the master branch and obviously fails to locate it. Will this be an issue when you rebuild the html or is this fine?