fix(nitro): restore 'import' condition for ssr resolve#35126
Merged
Conversation
@nuxt/kit
@nuxt/nitro-server
nuxt
@nuxt/rspack-builder
@nuxt/schema
@nuxt/vite-builder
@nuxt/webpack-builder
commit: |
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/fixtures/external-vue-resolution/modules/ssr-resolve-check.ts`:
- Around line 14-20: The check currently returns early when SSR resolve
`conditions` is missing, allowing the fixture to pass; instead, change the early
return to throw a hard error so missing SSR resolve conditions fail the test:
replace the `if (!conditions) { return }` with throwing a descriptive Error that
includes `conditions` context and `importer`, so the regression guard is
enforced; update the same block where `conditions` is read and where
`resolveModulePath(id, { try: true, from: importer, conditions })` and the
subsequent throw for unresolved modules are located.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f99ee8c2-0fa8-434f-8465-d86501ca2083
⛔ Files ignored due to path filters (2)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml,!pnpm-lock.yamltest/fixtures/external-vue-resolution/package.jsonis excluded by!**/package.json
📒 Files selected for processing (7)
packages/nitro-server/src/index.tspackages/nitro-server/src/utils.tstest/external-vue-resolution.test.tstest/fixtures/external-vue-resolution/app.vuetest/fixtures/external-vue-resolution/modules/ssr-resolve-check.tstest/fixtures/external-vue-resolution/nuxt.config.tstest/fixtures/external-vue-resolution/tsconfig.json
Merging this PR will not alter performance
Comparing 
Footnotes
|
andreiborza
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
May 20, 2026
…#21036) The explicit `pnpm add vue vue-router` step was added in #20519 as a temporary workaround for nuxt/nuxt#34888. This has been fixed upstream in nuxt/nuxt#35126.
This was referenced May 20, 2026
This was referenced Jun 1, 2026
This was referenced Jun 9, 2026
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #34888
af7a127
📚 Description
this reverts #34739 (cc: @yamachi4416) though we likely need to revisit this in future 🙏