Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[IMP] pos/viva: Update Viva.com doc #13848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

emmi-odoo
Copy link
Contributor

task-4745855

@emmi-odoo emmi-odoo requested a review from a team June 26, 2025 13:25
@robodoo
Copy link
Collaborator

robodoo commented Jun 26, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team June 26, 2025 13:43
@auva-odoo auva-odoo requested review from auva-odoo and removed request for a team June 30, 2025 05:29
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @emmi-odoo for this PR! I added a few comments and suggestion, including one about restructuring the configuration part of the doc. Let me know if you'd like to discuss it!

@emmi-odoo emmi-odoo force-pushed the 18.0-pos-viva-emmi branch from 70119c7 to f201012 Compare July 15, 2025 11:48
@emmi-odoo emmi-odoo requested a review from auva-odoo July 15, 2025 12:21
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this review @emmi-odoo, this version is a lot clearer and more straightforward, nice work! I added a few more comments and suggestions.

Also, I think the official name is viva.com (lower case) but I feel like sometimes with offical names that are not capitalize, they get lost a little bit in the text. I'll let you decide what you want to do in this case, but let's use the same terminology + capitalization throughout the whole doc here for consistency (and replace all of the "Viva" by "viva.com" at least, including in the terminal name 🙂 ).

I noticed that "Viva Wallet" is still used in some places in Odoo but if I’m not mistaken, it was changed to "Viva.com" in 18.3. We can update the documentation accordingly in the fw-port.

Thank you!

@emmi-odoo emmi-odoo force-pushed the 18.0-pos-viva-emmi branch 2 times, most recently from 4420a01 to 5902a7f Compare July 17, 2025 12:12
@emmi-odoo emmi-odoo requested a review from auva-odoo July 17, 2025 12:34
@auva-odoo auva-odoo force-pushed the 18.0-pos-viva-emmi branch from 5902a7f to 0175278 Compare July 18, 2025 06:46
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @emmi-odoo, thank you for the changes! I force-pushed some more minor ones

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants