-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Streamable HTTP support #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
good work, let's get this added in! |
@rm-openai Can you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets get this quickly to have agent sdk support the up-to-date standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akshit97 - this looks great, thank you! Can you just add some tests bc the len == 3
check is kinda fragile
src/agents/mcp/server.py
Outdated
@@ -105,7 +106,14 @@ async def connect(self): | |||
"""Connect to the server.""" | |||
try: | |||
transport = await self.exit_stack.enter_async_context(self.create_streams()) | |||
read, write = transport | |||
# Handle different transport return values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some unit tests to make sure this works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rm-openai Updated the check to discard the extra values and remove hard-coded checks. Do you want me to add unit tests right away or can I take that in a subsequent PR?
Also you'll probably need to increase the min version of |
It's already updated to 1.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. Yeah tests in a follow up PR sounds good - thank you
hmm can you run lint/fix typechecking? |
@rm-openai Fixed lint and typechecking issues. |
Been looking forward to this. Can't wait to try it in the next release. Thanks everyone. |
No description provided.