Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Streamable HTTP support #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 14, 2025
Merged

feat: Streamable HTTP support #643

merged 9 commits into from
May 14, 2025

Conversation

Akshit97
Copy link
Contributor

@Akshit97 Akshit97 commented May 2, 2025

No description provided.

@SoldierSacha
Copy link

good work, let's get this added in!

@Akshit97 Akshit97 marked this pull request as ready for review May 9, 2025 04:55
@Akshit97
Copy link
Contributor Author

Akshit97 commented May 9, 2025

@rm-openai Can you please review this?
python-sdk has released Streamable HTTP support
https://github.com/modelcontextprotocol/python-sdk/releases/tag/v1.8.0

Copy link

@Phillip-Kemper Phillip-Kemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets get this quickly to have agent sdk support the up-to-date standard.

Copy link
Collaborator

@rm-openai rm-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akshit97 - this looks great, thank you! Can you just add some tests bc the len == 3 check is kinda fragile

@@ -105,7 +106,14 @@ async def connect(self):
"""Connect to the server."""
try:
transport = await self.exit_stack.enter_async_context(self.create_streams())
read, write = transport
# Handle different transport return values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some unit tests to make sure this works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rm-openai Updated the check to discard the extra values and remove hard-coded checks. Do you want me to add unit tests right away or can I take that in a subsequent PR?

@rm-openai
Copy link
Collaborator

Also you'll probably need to increase the min version of mcp in the pyproject.toml

@Akshit97
Copy link
Contributor Author

Also you'll probably need to increase the min version of mcp in the pyproject.toml

It's already updated to 1.8.0

@Akshit97 Akshit97 requested a review from rm-openai May 14, 2025 16:06
Copy link
Collaborator

@rm-openai rm-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Yeah tests in a follow up PR sounds good - thank you

@rm-openai
Copy link
Collaborator

hmm can you run lint/fix typechecking?

@Akshit97
Copy link
Contributor Author

@rm-openai Fixed lint and typechecking issues.

@rm-openai rm-openai merged commit 1847008 into openai:main May 14, 2025
5 checks passed
@zantis
Copy link

zantis commented May 14, 2025

Been looking forward to this. Can't wait to try it in the next release. Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants