fix(exec): pass undefined instead of null for optional approval params #1414
+50
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeBox Type.Optional(Type.String()) accepts string|undefined but NOT null. Discord exec was failing with 'resolvedPath must be string' because callers passed null explicitly. Web UI worked because it skipped the approval request. Fixes exec approval validation error in Discord-triggered sessions.
47155dc to
de898c4
Compare
steipete
added a commit
that referenced
this pull request
Jan 22, 2026
Contributor
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type.Optional(Type.String())acceptsstring | undefinedbut NOTnullnullexplicitly, causing AJV validation to reject the requestrequiresAsk = false)Changes
src/agents/bash-tools.exec.ts: ChangeresolvedPath: null→undefined, remove?? nullfallbackssrc/cli/nodes-cli/register.invoke.ts: ChangeresolvedPath: null→undefined,sessionKey: null→undefinedsrc/gateway/server-methods/exec-approval.test.ts: Add regression tests documenting valid/invalid param valuesTest plan
pnpm test src/gateway/server-methods/exec-approval.test.tspasses (5 tests)pwd,echo hi)🤖 Generated with Claude Code