gNMI-1.10: Replacing component parent<->child relationship check with chassis association check#1195
Merged
Merged
Conversation
… chassis association check
Pull Request Test Coverage Report for Build 4319612882
💛 - Coveralls |
greg-dennis
suggested changes
Feb 26, 2023
greg-dennis
suggested changes
Feb 27, 2023
greg-dennis
suggested changes
Feb 27, 2023
greg-dennis
suggested changes
Feb 27, 2023
greg-dennis
previously approved these changes
Feb 27, 2023
greg-dennis
left a comment
Contributor
There was a problem hiding this comment.
approving for Go quality only
greg-dennis
previously approved these changes
Feb 27, 2023
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
sachendras
approved these changes
Mar 3, 2023
jasdeep-hundal
added a commit
to jasdeep-hundal/featureprofiles
that referenced
this pull request
Apr 11, 2023
jasdeep-hundal
added a commit
to jasdeep-hundal/featureprofiles
that referenced
this pull request
Apr 12, 2023
jasdeep-hundal
added a commit
that referenced
this pull request
Apr 19, 2023
) * Replicate PR545/546 in OTG telemetry basic test References: - #545 - #546 * Replicate PR642 in OTG telemetry basic test Reference: #642 * Replicate PR890 in OTG telemetry basic test Reference: #890 * Replicate PR1025 in OTG telemetry basic test Reference: #1025 * Replicate PR652 in OTG telemetry basic test Reference: #652 * Replicate PR1196 in OTG telemetry basic test Reference: #1196 * Replicate PR1195 in OTG telemetry basic test Reference: #1195 * Replicate PR1211 in OTG telemetry basic test Reference: #1211 * Replicate PR1248 in OTG telemetry basic test Reference: #1248 * Replicate PR1212 in OTG telemetry basic test Reference: #1212 * Replicate PR1317 in OTG telemetry basic test Reference: #1317 * Remove extra subintf enabled bit not guarded by correct deviations
prinikasn
pushed a commit
that referenced
this pull request
Jun 30, 2023
… chassis association check (#1195) * gNMI-1.10: Replacing component parent<->child relationship check with chassis association check * gNMI-1.10: Addressing review comments * gNMI-1.10: Addressing review comments - #2 * gNMI-1.10: Addressing review comments - iteration 3 * gNMI-1.10: Addressing review comments - iteration 4 * gNMI-1.10: Addressing review comments - iteration 5 * gNMI-1.10: Removing fabricChip from TestComponentParent
prinikasn
pushed a commit
that referenced
this pull request
Jun 30, 2023
) * Replicate PR545/546 in OTG telemetry basic test References: - #545 - #546 * Replicate PR642 in OTG telemetry basic test Reference: #642 * Replicate PR890 in OTG telemetry basic test Reference: #890 * Replicate PR1025 in OTG telemetry basic test Reference: #1025 * Replicate PR652 in OTG telemetry basic test Reference: #652 * Replicate PR1196 in OTG telemetry basic test Reference: #1196 * Replicate PR1195 in OTG telemetry basic test Reference: #1195 * Replicate PR1211 in OTG telemetry basic test Reference: #1211 * Replicate PR1248 in OTG telemetry basic test Reference: #1248 * Replicate PR1212 in OTG telemetry basic test Reference: #1212 * Replicate PR1317 in OTG telemetry basic test Reference: #1317 * Remove extra subintf enabled bit not guarded by correct deviations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component hierarchies could vary widely across vendor implementations and platforms. Also, OpenConfig does not require/enforce specific parent<->child relationships. The requirement around this test mainly is to be able to map various components in the device back to the top level chassis component (without placing any constraints on the number and type of intermediate nodes that may be present in the tree).
Modifying the test to fit the above by:
Also: