gnmi 1.10: add deviations MissingInterfacePhysicalChannel, MissingInterfaceHardwarePort, and MissingCPUMfgName#1248
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 4409279838
💛 - Coveralls |
guoshiuan
reviewed
Mar 10, 2023
| P4RTNodeName2 = flag.String("arg_p4rt_node_name_2", "", "The P4RT Node Name for the second FAP. Test that reserves ports in two different FAPs should configure this P4RT Node in addition to the Node defined in P4RTNodeName1. The value will only be used if deviation ExplicitP4RTNodeComponent is applied.") | ||
| FullConfigReplaceTime = flag.Duration("arg_full_config_replace_time", 0, "Time taken for gNMI set operation to complete full configuration replace. Expected duration is in nanoseconds. Expectation is not checked when value is 0.") | ||
| SubsetConfigReplaceTime = flag.Duration("arg_subset_config_replace_time", 0, "Time taken for gNMI set operation to modify a subset of configuration. Expected duration is in nanoseconds. Expectation is not checked when value is 0.") | ||
| QoSBaseConfigPresent = flag.Bool("arg_qos_baseconfig_present", false, "QoS Counter subtest in gNMI-1.10 requires related base config to be loaded. Use this flag to skip the when base config is not loaded.") |
Contributor
There was a problem hiding this comment.
The default value should be true, and I will change it for Cisco tests.
| FullConfigReplaceTime = flag.Duration("arg_full_config_replace_time", 0, "Time taken for gNMI set operation to complete full configuration replace. Expected duration is in nanoseconds. Expectation is not checked when value is 0.") | ||
| SubsetConfigReplaceTime = flag.Duration("arg_subset_config_replace_time", 0, "Time taken for gNMI set operation to modify a subset of configuration. Expected duration is in nanoseconds. Expectation is not checked when value is 0.") | ||
| QoSBaseConfigPresent = flag.Bool("arg_qos_baseconfig_present", false, "QoS Counter subtest in gNMI-1.10 requires related base config to be loaded. Use this flag to skip the when base config is not loaded.") | ||
| LACPBaseConfigPresent = flag.Bool("arg_lacp_baseconfig_present", false, "LACP subtest in gNMI-1.10 requires related base config to be loaded. Use this flag to skip the test when base config is not loaded.") |
Contributor
There was a problem hiding this comment.
The default value should be true, and I will change it for Cisco tests.
Contributor
|
b/272600177 has the internal test results. |
guoshiuan
approved these changes
Mar 10, 2023
Collaborator
|
Can we have internal bugs to track the deviations? Thanks. |
Contributor
Done. Please see them in the internal bug. |
jasdeep-hundal
added a commit
to jasdeep-hundal/featureprofiles
that referenced
this pull request
Apr 11, 2023
jasdeep-hundal
added a commit
to jasdeep-hundal/featureprofiles
that referenced
this pull request
Apr 12, 2023
jasdeep-hundal
added a commit
that referenced
this pull request
Apr 19, 2023
) * Replicate PR545/546 in OTG telemetry basic test References: - #545 - #546 * Replicate PR642 in OTG telemetry basic test Reference: #642 * Replicate PR890 in OTG telemetry basic test Reference: #890 * Replicate PR1025 in OTG telemetry basic test Reference: #1025 * Replicate PR652 in OTG telemetry basic test Reference: #652 * Replicate PR1196 in OTG telemetry basic test Reference: #1196 * Replicate PR1195 in OTG telemetry basic test Reference: #1195 * Replicate PR1211 in OTG telemetry basic test Reference: #1211 * Replicate PR1248 in OTG telemetry basic test Reference: #1248 * Replicate PR1212 in OTG telemetry basic test Reference: #1212 * Replicate PR1317 in OTG telemetry basic test Reference: #1317 * Remove extra subintf enabled bit not guarded by correct deviations
prinikasn
added a commit
that referenced
this pull request
Jun 30, 2023
…erfaceHardwarePort, and MissingCPUMfgName (#1248) * change test to assign interfaces to vrf after configuring them * Revert "change test to assign interfaces to vrf after configuring them" This reverts commit 98cc122. * increase timeout for awit call * Revert "increase timeout for awit call" This reverts commit 2ac995b. * add deviations MissingInterfacePhysicalChannel, MissingInterfaceHardwarePort, and MissingCPUMfgName * cleanup * cleanup * Update args.go * gofmt --------- Co-authored-by: prinikasn <[email protected]>
prinikasn
pushed a commit
that referenced
this pull request
Jun 30, 2023
) * Replicate PR545/546 in OTG telemetry basic test References: - #545 - #546 * Replicate PR642 in OTG telemetry basic test Reference: #642 * Replicate PR890 in OTG telemetry basic test Reference: #890 * Replicate PR1025 in OTG telemetry basic test Reference: #1025 * Replicate PR652 in OTG telemetry basic test Reference: #652 * Replicate PR1196 in OTG telemetry basic test Reference: #1196 * Replicate PR1195 in OTG telemetry basic test Reference: #1195 * Replicate PR1211 in OTG telemetry basic test Reference: #1211 * Replicate PR1248 in OTG telemetry basic test Reference: #1248 * Replicate PR1212 in OTG telemetry basic test Reference: #1212 * Replicate PR1317 in OTG telemetry basic test Reference: #1317 * Remove extra subintf enabled bit not guarded by correct deviations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull adds three deviations MissingInterfacePhysicalChannel, MissingInterfaceHardwarePort, and MissingCPUMfgName to skips the checks for interface/physicalchannel, interface/hardwareport, component/MfgName accordingly.
Also, two of the subtests for QoS counter and LACP member assume the device already has base config for QoS and LACP. So, we add two arguments to skip the test when related base config is not loaded.