Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Explicitly prefer legacy GL in cmake on Linux? #22836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2024
Merged

Explicitly prefer legacy GL in cmake on Linux? #22836

merged 2 commits into from
Jul 5, 2024

Conversation

@kallaballa
Copy link
Contributor

@kallaballa kallaballa commented Nov 20, 2022 •
edited
Loading

Pertaining Issue: #22835

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@kallaballa
Copy link
Contributor Author

kallaballa commented Nov 21, 2022 •
edited
Loading

I am not so sure about that choice anymore. Because I made more research on #22704 and found the following statement "It allows EGL and GLX to coexist in the same process." here: https://www.x.org/wiki/Events/XDC2017/brenneman_GLVND.pdf

Also, at least on my system all the binaries that link EGL and GLX also link libGLdispatch as well. Including the opencv that is shipped with OpenSuse. Need to do more research and tests.

@asmorkalov asmorkalov requested a review from alalek November 21, 2022 11:11
@asmorkalov asmorkalov added this to the 4.7.0 milestone Nov 21, 2022
@kallaballa
Copy link
Contributor Author

kallaballa commented Nov 23, 2022 •
edited
Loading

I did some experiments using GLVND. Including running a program using CL/GL (through EGL), CL/VA and highgui (imshow based on QT - with and without OpenGL). I'd also like to stress any code that uses the gl:: functions (which are loaded via GLX on Linux) but it seems like it isn't used in OpenCV and OpenCV_contrib. Where can I find code that relies on those functions? Can you think of good tests and other subsystems that might be affected?

Anyway I couldn't find any problems yet.

In legacy mode (with EGL patch enabled) the following libraries are linked to the OpenCV core so:

	linux-vdso.so.1 (0x00007ffe38bd5000)
	libz.so.1 => /usr/lib64/libz.so.1 (0x00007f8d2d23c000)
	libGL.so.1 => /usr/lib64/libGL.so.1 (0x00007f8d2bf73000)
	libEGL.so.1 => /usr/lib64/libEGL.so.1 (0x00007f8d2d228000)
	libopenblas_pthreads.so.0 => /usr/lib64/libopenblas_pthreads.so.0 (0x00007f8d2a200000)
	libstdc++.so.6 => /usr/lib64/libstdc++.so.6 (0x00007f8d29e00000)
	libm.so.6 => /usr/lib64/libm.so.6 (0x00007f8d2a11c000)
	libgcc_s.so.1 => /usr/lib64/libgcc_s.so.1 (0x00007f8d2a0fb000)
	libc.so.6 => /usr/lib64/libc.so.6 (0x00007f8d29c05000)
	libGLX.so.0 => /usr/lib64/libGLX.so.0 (0x00007f8d2a0c9000)
	libGLdispatch.so.0 => /usr/lib64/libGLdispatch.so.0 (0x00007f8d29b4e000)
	libgfortran.so.5 => /usr/lib64/libgfortran.so.5 (0x00007f8d29800000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f8d2d25c000)
	libX11.so.6 => /usr/lib64/libX11.so.6 (0x00007f8d296ba000)
	libquadmath.so.0 => /usr/lib64/libquadmath.so.0 (0x00007f8d2a082000)
	libxcb.so.1 => /usr/lib64/libxcb.so.1 (0x00007f8d2a057000)
	libXau.so.6 => /usr/lib64/libXau.so.6 (0x00007f8d2d21f000)

In GLVND mode (with EGL patch enabled) the following libraries are linked to the OpenCV core so:

	linux-vdso.so.1 (0x00007ffdc6a61000)
	libz.so.1 => /usr/lib64/libz.so.1 (0x00007f3c8be77000)
	libGLX.so.0 => /usr/lib64/libGLX.so.0 (0x00007f3c8be45000)
	libEGL.so.1 => /usr/lib64/libEGL.so.1 (0x00007f3c8be31000)
	libopenblas_pthreads.so.0 => /usr/lib64/libopenblas_pthreads.so.0 (0x00007f3c88e90000)
	libstdc++.so.6 => /usr/lib64/libstdc++.so.6 (0x00007f3c88c00000)
	libm.so.6 => /usr/lib64/libm.so.6 (0x00007f3c88b1c000)
	libgcc_s.so.1 => /usr/lib64/libgcc_s.so.1 (0x00007f3c88e6f000)
	libc.so.6 => /usr/lib64/libc.so.6 (0x00007f3c88921000)
	libX11.so.6 => /usr/lib64/libX11.so.6 (0x00007f3c887db000)
	libGLdispatch.so.0 => /usr/lib64/libGLdispatch.so.0 (0x00007f3c88724000)
	libgfortran.so.5 => /usr/lib64/libgfortran.so.5 (0x00007f3c88400000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f3c8be97000)
	libxcb.so.1 => /usr/lib64/libxcb.so.1 (0x00007f3c88e44000)
	libquadmath.so.0 => /usr/lib64/libquadmath.so.0 (0x00007f3c886dd000)
	libXau.so.6 => /usr/lib64/libXau.so.6 (0x00007f3c8be28000)

So in both cases GLX, EGL and libGLdispatch are linked but in GLVND mode the old libGL isn't. So actually GLVND looks like the safer and better choice to me since it removes a dependency that has been deprecated since 2008.

@kallaballa kallaballa changed the title Explicitly prefer legacy GL in cmake on Linux Explicitly prefer legacy GL in cmake on Linux? Nov 23, 2022
@kallaballa
Copy link
Contributor Author

kallaballa commented Nov 23, 2022

Btw. because it has been abstracted well, replacing GLX based function pointer loading for Linux could easily be replaced with an EGL call.

opencv/modules/core/src/gl_core_3_1.cpp

Lines 131 to 133 in 6ca205a

#include <GL/glx.h>
#define CV_GL_GET_PROC_ADDRESS(name) glXGetProcAddressARB((const GLubyte*) name)

@kallaballa kallaballa mentioned this pull request Nov 23, 2022
Open
6 tasks
@kallaballa
Copy link
Contributor Author

kallaballa commented Nov 23, 2022

From this point i will document the progress on GLVND+EGL in PR #22704 because I have come to the conclusion that those decisions are linked and I want a single point of information.

@asmorkalov asmorkalov modified the milestones: 4.8.0, 4.9.0 Jun 27, 2023
@opencv-alalek opencv-alalek removed the request for review from alalek August 16, 2023 22:48
@asmorkalov asmorkalov modified the milestones: 4.9.0, 4.10.0 Dec 19, 2023
@asmorkalov asmorkalov modified the milestones: 4.10.0, 4.11.0 Apr 27, 2024
@asmorkalov asmorkalov self-requested a review July 5, 2024 11:15
@asmorkalov asmorkalov force-pushed the opengl_cmake_warning_linux branch from 98acc78 to bb58dbc Compare July 5, 2024 11:16
asmorkalov
asmorkalov approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good for now. Works on EGL path now.

opencv-alalek
opencv-alalek reviewed Jul 5, 2024
View reviewed changes
@asmorkalov
Copy link
Contributor

asmorkalov commented Jul 5, 2024

Tested manually with Ubuntu 18.04 GTK/QT and Ubuntu 24.04 GTK/QT

@asmorkalov asmorkalov self-assigned this Jul 5, 2024
@asmorkalov asmorkalov closed this Jul 5, 2024
@asmorkalov asmorkalov reopened this Jul 5, 2024
@asmorkalov asmorkalov merged commit d7a237a into opencv:4.x Jul 5, 2024
@asmorkalov asmorkalov mentioned this pull request Jul 16, 2024
Merged
@xkszltl xkszltl mentioned this pull request Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@opencv-alalek opencv-alalek opencv-alalek left review comments

Assignees

@asmorkalov asmorkalov

Labels

category: build/install

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@kallaballa @asmorkalov @opencv-alalek @alalek