-
-
Notifications
You must be signed in to change notification settings - Fork 56.4k
Make \epsilon parameter accessible in VariationalRefinement #24852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@opencv-alalek could you tune ABI checker configuration. |
asmorkalov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
It would be great to add this parameter to dis_flow.cpp float getVariationalRefinementEpsilon() const CV_OVERRIDE { return variational_refinement_epsilon; }
void setVariationalRefinementEpsilon(float val) CV_OVERRIDE { variational_refinement_epsilon = val; }and variational_refinement_processors[i]->setEpsilon(variational_refinement_epsilon);and in tracking.hpp /** @brief Charbonier Robust metric term
@see setVariationalRefinementEpsilon */
CV_WRAP virtual float getVariationalRefinementEpsilon() const = 0;
/** @copybrief getVariationalRefinementEpsilon @see getVariationalRefinementEpsilon */
CV_WRAP virtual void setVariationalRefinementEpsilon(float val) = 0;Or may be it is better to create an other issue ? |
Perhaps there's no need to open a new issue; I have already attempted to make the necessary modifications. |
|
I apologize as this is my first attempt to submit a pr to opencv, and I lack some experience. Why this workflow is stuck? How should I proceed to resolve it? |
asmorkalov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Resolves #24847
I believe this is necessary to expose \epsilon parameter.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.