Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Burnside999
Copy link
Contributor

Resolves #24847
I believe this is necessary to expose \epsilon parameter.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Contributor

@opencv-alalek could you tune ABI checker configuration.

@asmorkalov asmorkalov added this to the 4.10.0 milestone Jan 12, 2024
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeffwitz
Copy link

jeffwitz commented Jan 14, 2024

It would be great to add this parameter to dis_flow.cpp

    float getVariationalRefinementEpsilon() const CV_OVERRIDE { return variational_refinement_epsilon; }
    void setVariationalRefinementEpsilon(float val) CV_OVERRIDE { variational_refinement_epsilon = val; }

and

variational_refinement_processors[i]->setEpsilon(variational_refinement_epsilon);

and in tracking.hpp

    /** @brief Charbonier Robust metric term
    @see setVariationalRefinementEpsilon */
    CV_WRAP virtual float getVariationalRefinementEpsilon() const = 0;
    /** @copybrief getVariationalRefinementEpsilon @see getVariationalRefinementEpsilon  */
    CV_WRAP virtual void setVariationalRefinementEpsilon(float val) = 0;

Or may be it is better to create an other issue ?

@Burnside999
Copy link
Contributor Author

It would be great to add this parameter to dis_flow.cpp

    float getVariationalRefinementEpsilon() const CV_OVERRIDE { return variational_refinement_epsilon; }
    void setVariationalRefinementEpsilon(float val) CV_OVERRIDE { variational_refinement_epsilon = val; }

and

variational_refinement_processors[i]->setEpsilon(variational_refinement_epsilon);

and in tracking.hpp

    /** @brief Charbonier Robust metric term
    @see setVariationalRefinementEpsilon */
    CV_WRAP virtual float getVariationalRefinementEpsilon() const = 0;
    /** @copybrief getVariationalRefinementEpsilon @see getVariationalRefinementEpsilon  */
    CV_WRAP virtual void setVariationalRefinementEpsilon(float val) = 0;

Or may be it is better to create an other issue ?

Perhaps there's no need to open a new issue; I have already attempted to make the necessary modifications.

@Burnside999
Copy link
Contributor Author

I apologize as this is my first attempt to submit a pr to opencv, and I lack some experience. Why this workflow is stuck? How should I proceed to resolve it?

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 6c39fbc into opencv:4.x Jan 17, 2024
@asmorkalov asmorkalov mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get Access to \epsilon parameter of the charbonier norm (Brox2004) in VariationalRefinement

3 participants