Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update package.json exports for types imports #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2025
Merged

Update package.json exports for types imports #747

merged 3 commits into from
Feb 19, 2025

Conversation

nhardy
Copy link
Contributor

@nhardy nhardy commented Feb 18, 2025

Updates the package.json exports field to split into default and types to fix issue with TypeScript being unable to reference types such as:

import type { OpenNextConfig } from "open-next/types/open-next";

Error message: Cannot find module 'open-next/types/open-next' or its corresponding type declarations. ts(2307)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2511183

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 18, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@747

commit: 2511183

vicb
vicb reviewed Feb 19, 2025
View reviewed changes
vicb
vicb reviewed Feb 19, 2025
View reviewed changes
vicb
vicb approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

conico974
conico974 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@conico974 conico974 merged commit f96dac7 into opennextjs:main Feb 19, 2025
3 checks passed
@james-elicx james-elicx mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb approved these changes

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhardy @vicb @conico974