return meta files from createAssets() #748
Conversation
|
commit: |
| @@ -22,6 +22,13 @@ | |||
| "types": "./dist/*.d.ts" | |||
| } | |||
| }, | |||
| "typesVersions": { | |||
There was a problem hiding this comment.
Would "types": "dist/*" work here?
Could the problem be that we import path.js instead of path (would be awesome to be able to drop the .js but it might be a breaking change)
Anyway do not spend too much time on this if you have a working config.
There was a problem hiding this comment.
Could the problem be that we import path.js instead of path (would be awesome to be able to drop the .js but it might be a breaking change)
I don't think so, i've tested this on a test repo that i had and it worked. I was even able to drop the .js.
If we need typesVersions to not break compatibility i'm fine with it
There was a problem hiding this comment.
unfortunately same problem
| @@ -22,6 +22,13 @@ | |||
| "types": "./dist/*.d.ts" | |||
| } | |||
| }, | |||
| "typesVersions": { | |||
There was a problem hiding this comment.
Could the problem be that we import path.js instead of path (would be awesome to be able to drop the .js but it might be a breaking change)
I don't think so, i've tested this on a test repo that i had and it worked. I was even able to drop the .js.
If we need typesVersions to not break compatibility i'm fine with it
2a6c1ac to
596aa36
Compare
I want to re-use the value instead of importing the generated file.
I also had to add back the
typesVersionsthat was removed in #747 as it broke builds and imports for the cloudflare adapter.