fix: handle shared-cache-controls rename #2974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3eae1b to
fe07468
Compare
📊 Package size report 0.02%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
commented
Jun 24, 2025
Comment on lines
+30
to
+39
| /** @type {import('next').GetStaticPaths} */ | ||
| export const getStaticPaths = ({ locales }) => { | ||
| return { | ||
| paths: [ | ||
| { | ||
| params: { | ||
| slug: 'prerendered', | ||
| }, | ||
| }, | ||
| ], | ||
| ].flatMap((pathDescription) => locales.map((locale) => ({ ...pathDescription, locale }))), |
There was a problem hiding this comment.
This was wrong setup which was resulting in not prerendering not-default locale. This make sure that prerendered page is actually prerendered for all locales.
This "fixes" one of the e2e failure that was supposed to be testing prerendered case for non default locale, but in practice it was testing not prerendered case
|
Remaining 3 failing tests are result of this regression in Next.js vercel/next.js#80838 . Tests likely will still need to be adjusted at least a little bit if caching issue is addressed still, but there doesn't seem to be a point in addressing those now until there is a fix for cache-control for fallback: true pages in Next.js |
mrstork
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was some changes in
next@canarybut break some of our handling. This address one of them. Remaining failing tests are results of regression innext@canary(see vercel/next.js#80838 ) which hopefully be addressed in Next.js.Documentation
Tests
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal