fix(dialog-box): [dialog-box] right pop-up window height style issue #2844
Conversation
WalkthroughThe pull request focuses on modifying the dialog box's styling in the Less stylesheet, specifically for the right-slide drawer state. The changes involve updating the padding configuration and introducing a new Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request addresses a bug in the dialog-box component related to the height style of the right pop-up window. The changes involve updating the padding and setting a maximum height to ensure the dialog box displays correctly. Changes
|
| @@ -182,7 +182,8 @@ | |||
| overflow: auto; | |||
| color: var(--tv-DialogBox-drawer-body-color); | |||
| border-bottom: 1px solid var(--tv-DialogBox-drawer-divider-border-color); | |||
| padding: 0 var(--tv-DialogBox-padding); | |||
| padding: var(--tv-DialogBox-vertical-padding) var(--tv-DialogBox-padding); | |||
| max-height: 100vh; | |||
There was a problem hiding this comment.
Ensure that the max-height: 100vh; does not interfere with any dynamic content that might exceed this height, as it could lead to content being cut off or inaccessible.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/theme/src/dialog-box/index.less(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
| padding: var(--tv-DialogBox-vertical-padding) var(--tv-DialogBox-padding); | ||
| max-height: 100vh; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider a more robust height calculation approach.
While the padding changes look good, setting max-height: 100vh might cause issues:
- Content could overflow or be cut off since the drawer has header and footer sections
- Mobile browsers with dynamic toolbars can cause inconsistent viewport heights
Consider this alternative approach:
.@{dialog-box-prefix-cls}__body {
flex: 1;
overflow: auto;
color: var(--tv-DialogBox-drawer-body-color);
border-bottom: 1px solid var(--tv-DialogBox-drawer-divider-border-color);
padding: var(--tv-DialogBox-vertical-padding) var(--tv-DialogBox-padding);
- max-height: 100vh;
+ max-height: calc(100vh - var(--tv-DialogBox-padding) * 2 - var(--tv-DialogBox-header-height) - var(--tv-DialogBox-footer-height));
+ /* Add a CSS variable for dynamic viewport height support */
+ max-height: calc(100dvh - var(--tv-DialogBox-padding) * 2 - var(--tv-DialogBox-header-height) - var(--tv-DialogBox-footer-height));
}This change:
- Accounts for header/footer heights and padding
- Uses
dvhunit as a fallback for browsers that support dynamic viewport units - Relies on CSS variables for maintainable height calculations
Note: You'll need to define the header and footer height variables in your vars.less file.
Committable suggestion skipped: line range outside the PR's diff.
PR
修改前：
修改后：
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit