fix(dialog-box): [dialog-box] modify the full screen content height of the dialog box component not being fully supported #2947

James-9696 · 2025-02-21T08:28:04Z

…t not being fully supported

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Style
- Enhanced the full-screen dialog box appearance by capping its content area's maximum height to the viewport height, ensuring improved content display and scrolling behavior.

…t not being fully supported

coderabbitai · 2025-02-21T08:28:13Z

Walkthrough

The pull request updates the dialog box component's styling by adding a new CSS property—max-height: 100vh;—to the &__body class under the fullscreen (.is-fullscreen) context. This change ensures that when the dialog box is maximized, its content does not exceed the viewport height, while retaining the existing flex and overflow properties.

Changes

File(s)	Change Summary
`packages/theme/.../dialog-box/index.less`	Added `max-height: 100vh;` in the `&__body` class under the `.is-fullscreen` context to restrict its height to the viewport while keeping `flex: 1;` and `overflow: scroll;` unchanged.

Possibly related PRs

fix(dialog-box): [dialog-box] modify the style of the dialog box #2757: Modified the &__body styling in the dialog box component, addressing height and overflow properties in a similar context.
fix(dialog-box): [dialog-box] modify demo #2421: Involved changes to the dialog box’s max-height, directly relating to the handling of fullscreen display attributes.
fix(dialog-box): [dialog-box] right pop-up window height style issue #2844: Introduced max-height: 100vh; in a different context (&.is-right-slide), connecting to this PR’s focus on dialog box height styling.

Suggested labels

bug

Suggested reviewers

zzcr

Poem

I'm a rabbit, hopping with glee,
Updating styles for all to see.
The dialog box now stands so tall,
With a max height that embraces all.
In the code garden, I dance and play—
Hoppy changes lead the way!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

petercat-assistant · 2025-02-21T08:28:17Z

Walkthrough

This pull request addresses a bug in the dialog-box component where the full screen content height was not being fully supported. The change involves modifying the CSS to ensure the dialog box content can utilize the full viewport height.

Changes

File	Summary
packages/theme/src/dialog-box/index.less	Added `max-height: 100vh;` to ensure the dialog box content can fully utilize the viewport height when in fullscreen mode.

petercat-assistant · 2025-02-21T08:28:20Z

packages/theme/src/dialog-box/index.less

@@ -56,6 +56,7 @@
  &.is-fullscreen &__body {
    flex: 1;
    overflow: scroll;
+    max-height: 100vh;


Ensure that max-height: 100vh; does not interfere with any other styles or cause unexpected behavior in different screen sizes or orientations.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/theme/src/dialog-box/index.less (1)

56-60: Improve Fullscreen Dialog Body Layout

The addition of max-height: 100vh; within the .is-fullscreen &__body block is a solid fix to ensure the dialog box content does not exceed the viewport height when in fullscreen mode. This change, combined with flex: 1; and overflow: scroll;, helps maintain a usable layout even when dialog content is extensive.

Nitpick: Consider whether using overflow-y: auto; instead of overflow: scroll; might better suit the design—this would display a vertical scrollbar only when needed, avoiding unnecessary horizontal scrollbars.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37f3f45 and 8755fbe.

📒 Files selected for processing (1)

packages/theme/src/dialog-box/index.less (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: PR E2E Test (pnpm test:e2e3)

fix: modify the full screen content height of the dialog box componen…

8755fbe

…t not being fully supported

github-actions bot added the bug Something isn't working label Feb 21, 2025

petercat-assistant bot reviewed Feb 21, 2025

View reviewed changes

coderabbitai bot reviewed Feb 21, 2025

View reviewed changes

zzcr approved these changes Feb 22, 2025

View reviewed changes

zzcr merged commit 47050d0 into dev Feb 22, 2025
10 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dialog-box): [dialog-box] modify the full screen content height of the dialog box component not being fully supported #2947

fix(dialog-box): [dialog-box] modify the full screen content height of the dialog box component not being fully supported #2947

James-9696 commented Feb 21, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 21, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

petercat-assistant bot commented Feb 21, 2025

petercat-assistant bot Feb 21, 2025

coderabbitai bot left a comment

fix(dialog-box): [dialog-box] modify the full screen content height of the dialog box component not being fully supported #2947

fix(dialog-box): [dialog-box] modify the full screen content height of the dialog box component not being fully supported #2947

Conversation

James-9696 commented Feb 21, 2025 • edited by coderabbitai bot Loading

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

coderabbitai bot commented Feb 21, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

petercat-assistant bot commented Feb 21, 2025

Walkthrough

Changes

petercat-assistant bot Feb 21, 2025

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

James-9696 commented Feb 21, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)