Thanks to visit codestin.com
Credit goes to github.com

Skip to content

πŸ“– [doc] Initial draft doc preflight perms #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bentito
Copy link
Contributor

@bentito bentito commented May 6, 2025

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2025
Copy link

netlify bot commented May 6, 2025

βœ… Deploy Preview for olmv1 ready!

Name Link
πŸ”¨ Latest commit 5c7bb63
πŸ” Latest deploy log https://app.netlify.com/sites/olmv1/deploys/682259cc2e97ae000879a9d5
😎 Deploy Preview https://deploy-preview-1950--olmv1.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 66.82%. Comparing base (540804c) to head (5c7bb63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1950      +/-   ##
==========================================
+ Coverage   66.78%   66.82%   +0.04%     
==========================================
  Files          75       75              
  Lines        6337     6337              
==========================================
+ Hits         4232     4235       +3     
+ Misses       1841     1839       -2     
+ Partials      264      263       -1     
Flag Coverage Ξ”
e2e 45.25% <ΓΈ> (+0.06%) ⬆️
unit 56.38% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
Copy link

openshift-ci bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelryanpeter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2025
@bentito
Copy link
Contributor Author

bentito commented May 12, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2025
@bentito bentito marked this pull request as ready for review May 12, 2025 20:27
@bentito bentito requested a review from a team as a code owner May 12, 2025 20:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
Copy link

openshift-ci bot commented May 12, 2025

New changes are detected. LGTM label has been removed.

@bentito bentito changed the title [πŸ“– ] WIP Initial draft doc preflight perms [πŸ“– ] Initial draft doc preflight perms May 12, 2025
@bentito bentito changed the title [πŸ“– ] Initial draft doc preflight perms [πŸ“–] Initial draft doc preflight perms May 12, 2025
@bentito bentito changed the title [πŸ“–] Initial draft doc preflight perms πŸ“– [doc] Initial draft doc preflight perms May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants