Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[πŸ“– ] WIP Initial draft doc preflight perms #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bentito
Copy link
Contributor

@bentito bentito commented May 6, 2025

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2025
Copy link

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign michaelryanpeter for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented May 6, 2025

βœ… Deploy Preview for olmv1 ready!

Name Link
πŸ”¨ Latest commit 8bab988
πŸ” Latest deploy log https://app.netlify.com/sites/olmv1/deploys/681a1992d9cf7b00089e5c85
😎 Deploy Preview https://deploy-preview-1950--olmv1.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 66.77%. Comparing base (061da6a) to head (8bab988).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1950      +/-   ##
==========================================
- Coverage   66.81%   66.77%   -0.05%     
==========================================
  Files          75       75              
  Lines        6335     6335              
==========================================
- Hits         4233     4230       -3     
- Misses       1839     1841       +2     
- Partials      263      264       +1     
Flag Coverage Ξ”
e2e 45.21% <ΓΈ> (-0.07%) ⬇️
unit 56.35% <ΓΈ> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant