-
Notifications
You must be signed in to change notification settings - Fork 37
feat: Semantic Versioning #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thomaszurkan-optimizely
merged 39 commits into
optimizely:master
from
AmnaEjaz:amna/semver
Sep 17, 2020
Merged
Changes from 4 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
ac7e81f
feat:semantic versioning
ee29674
semver updated
4a5e75d
more validation for invalid cases added
01ed4da
feat: Semantic Version
oakbani 796af4d
GE and LE with test cases
f318995
Update test_condition.py
e016cd8
added ge le
msohailhussain 857e8de
PR comments resolved
5f793a3
comments resolved
cfb12df
Update condition.py
379d637
Merge branch 'uzair/semver' into amna/semver
oakbani 1c37fbf
invalid test case for semver and comment fixed
dcd391f
Update test_condition.py
2affb9d
Update test_condition.py
032d9c1
Merge branch 'uzair/semver' into amna/semver
oakbani 8577f7c
compare implemetation and invalid testcase fixed
32bed45
Merge branch 'uzair/semver' into amna/semver
oakbani 426d2b7
Revert "compare implemetation and invalid testcase fixed"
oakbani ac8113e
passes fsc at this point
oakbani 84f6c26
fix:lint
oakbani ca7984a
remove: additional lint fixes
oakbani 9256e6a
additional removal
oakbani 15fa71b
further removal
oakbani 8414a92
address most comments
oakbani 78ce524
reorganize
oakbani aa1fbaf
tests: revised all unit tests
oakbani c8c0e75
Merge branch 'master' into amna/semver
oakbani 907fcf2
address comments
oakbani 8b4567c
add further checks
oakbani 8856665
comments resolved
7ed20f0
comments resolved
4f2c05e
Update test_condition.py
4070805
Revert "Update test_condition.py"
4c471bd
Update test_condition.py
68708d9
Update test_condition.py
09533b1
Merge branch 'master' into amna/semver
msohailhussain ad17c02
testcase fixed
93cbb2a
Update condition.py
25ab44d
fix condition
oakbani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,9 +105,6 @@ def is_pre_release(self, target): | |
""" | ||
return SemverType.IS_PRE_RELEASE in target | ||
|
||
def is_patch_pre_release(self, idx, idx_value): | ||
return idx == SemverType.PATCH_INDEX and idx_value in SemverType.IS_PATCH_PRE_RELEASE | ||
|
||
def is_build(self, target): | ||
""" Method to check if the given version contains "+" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again. Similar to the comment above. This should be |
||
|
||
|
@@ -499,14 +496,14 @@ def split_semantic_version(self, target): | |
target_suffix = "" | ||
target_parts = [] | ||
|
||
""" remove spaces from target version string """ | ||
# remove spaces from target version string | ||
|
||
if self.has_white_space(target): | ||
self.logger.warning(Errors.INVALID_ATTRIBUTE_FORMAT) | ||
return None | ||
|
||
# check for pre release e.g. 1.0.0-alpha where 'alpha' is a pre release | ||
# otherwise check for build e.g. 1.0.0+001 where 001 is a build metadata""" | ||
# otherwise check for build e.g. 1.0.0+001 where 001 is a build metadata | ||
|
||
if self.is_pre_release(target): | ||
target_parts = target.split(SemverType.IS_PRE_RELEASE) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if version includes multiple "-"?
Can you share some sample pre-release versions here? Also, will be good to put same information in docstring itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version having multiple "-" should be invalid right? We haven't dealt with this here. @thomaszurkan-optimizely