feat: Semantic Versioning #293
semver updated
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # Copyright 2016-2020, Optimizely | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
|
|
@@ -122,165 +122,162 @@ def test_evaluate__returns_null__when_condition_has_an_invalid_type_property(sel | |
|
|
||
| self.assertIsNone(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_matches_target_version_2(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_equal_2_condition_list, {'Android': '2'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_2_matches_target_version_2(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_equal_2_condition_list, {'Android': '2.2'}, self.mock_client_logger | ||
|
There was a problem hiding this comment. How is this set true? There was a problem hiding this comment. Comparison is made upto the len of target version. The target version is set to 2 here. @thomaszurkan-optimizely |
||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_0_matches_target_version_2_0(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_equal_2_0_condition_list, {'Android': '2.0'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_0_0_matches_target_version_2_0_0(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_equal_2_0_0_condition_list, {'Android': '2.0.0'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_false__when_user_version_2_0_does_not_match_target_version_2_0(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_equal_2_0_0_condition_list, {'Android': '2.0'}, self.mock_client_logger | ||
|
There was a problem hiding this comment. Same reason as above. The target version has been defined to higher precision 2.0.0. And the user version is only 2.0 |
||
| ) | ||
|
|
||
| self.assertStrictFalse(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_0_0_release_is_greater_than_target_version_2_0_0_beta( | ||
| self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_greater_than_2_0_0_beta_condition_list, {'Android': '2.0.0-release'}, self.mock_client_logger | ||
|
There was a problem hiding this comment. It is greater because release > beta? |
||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_0_1_is_greater_than_target_version__2_0_0(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_greater_than_2_0_0_condition_list, {'Android': '2.0.1'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_1_9_9_is_less_than_target_version_2_0_0(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_less_than_2_0_0_condition_list, {'Android': '1.9.9'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_1_9_0_beta_is_less_than_target_version_2_0_0(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_less_than_2_0_0_condition_list, {'Android': '1.9.0-beta'}, self.mock_client_logger | ||
|
There was a problem hiding this comment. I think it will get better to compare 2.0.0-beta against 2.0.0 There was a problem hiding this comment. How is this test different from test_evaluate__returns_true__when_user_version_2_0_0_beta_is_less_than_target_version_2_0_0_release ? We are not learning anything new. There was a problem hiding this comment. Yeah, removed this one. The other that you mentioned should suffice. |
||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_0_0_release_is_less_than_target_version_2_0_0(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_less_than_2_0_0_condition_list, {'Android': '2.0.0-release'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_0_0_beta_is_less_than_target_version_2_0_0_release(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_less_than_2_0_0_release_condition_list, {'Android': '2.0.0-beta'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_false__when_user_version_2_0_0_release_is_not_less_than_target_version_2_0_0_beta(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_less_than_2_0_0_beta_condition_list, {'Android': '2.0.0-release'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictFalse(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_0_9_is_greater_than_or_equal_to_target_version_2_0_9(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_greater_than_or_equal_2_0_9_condition_list, {'Android': '2.0.9'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_3_is_greater_than_or_equal_to_target_version_2_0_9(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_greater_than_or_equal_2_0_9_condition_list, {'Android': '2.3'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_0_9_beta_is_greater_than_or_equal_to_target_version_2_0_9_beta( | ||
| self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_greater_than_or_equal_2_0_9_beta_condition_list, {'Android': '2.0.9-beta'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_false__when_user_version_1_0_0_is_not_greater_than_or_equal_to_target_version_2_0_9( | ||
| self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_greater_than_or_equal_2_0_9_condition_list, {'Android': '1.0.0'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictFalse(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_0_1_is_less_than_or_equal_to_target_version_2_0_1(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_less_than_or_equal_2_0_1_condition_list, {'Android': '2.0.1'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_1_1_is_less_than_or_equal_to_target_version_2_0_1(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_less_than_or_equal_2_0_1_condition_list, {'Android': '1.1'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_true__when_user_version_2_0_1_beta_is_less_than_or_equal_to_target_version_2_0_1(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_less_than_or_equal_2_0_1_condition_list, {'Android': '2.0.1-beta'}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_false__when_user_version_3_0_1_is_not_less_than_or_equal_to_target_version_2_0_1(self): | ||
|
|
||
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_less_than_or_equal_2_0_1_condition_list, {'Android': '3.0.1'}, self.mock_client_logger | ||
|
|
@@ -304,27 +301,33 @@ def test_evaluate__returns_null__when_user_provided_version_is_null(self): | |
|
|
||
| self.assertIsNone(evaluator.evaluate(0)) | ||
|
|
||
| def test_evaluate__returns_exception__when_user_provided_version_is_invalid1(self): | ||
|
|
||
| condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_equal_2_0_condition_list, {'Android': "+"}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertRaises(Exception) | ||
|
|
||
| def test_evalduate__returns_exception__when_user_provided_version_is_invalid2(self): | ||
|
|
||
| condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_equal_2_0_condition_list, {'Android': "+--"}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertRaises(Exception) | ||
|
|
||
| def test_evalduate__returns_exception__when_user_provided_version_is_invalid3(self): | ||
|
|
||
| condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_equal_2_0_condition_list, {'Android': "...+"}, self.mock_client_logger | ||
| ) | ||
|
|
||
| self.assertRaises(Exception) | ||
|
|
||
| def test_evalduate__returns_exception__when_user_provided_version_is_invalid4(self): | ||
|
|
||
| condition_helper.CustomAttributeConditionEvaluator( | ||
| semver_equal_2_0_condition_list, {'Android': "+test"}, self.mock_client_logger | ||
| ) | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. Indentation is off. This needs to align with the quotes above.