Codestin Search App

camc314 · 2026-09-10T16:26:06Z

No description provided.

camc314 · 2026-09-10T16:26:22Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

test(codegen): benchmark without sourcemap #26540 👈 (View in Graphite)
test(codegen): benchmark ASCII-only output #26538
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

chatgpt-codex-connector · 2026-09-10T16:26:48Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-10T16:37:03.227601Z	`c77cd1e`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e7bdc36a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codspeed-hq · 2026-09-10T16:30:49Z

Merging this PR will improve performance by ×2.5

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
✅ 67 untouched benchmarks
🆕 10 new benchmarks
⏩ 9 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`codegen[binder.ts]`	8.8 ms	2.9 ms	×3
⚡	Simulation	`codegen_ascii_only[binder.ts]`	8.8 ms	3 ms	×3
⚡	Simulation	`codegen[react.development.js]`	4.2 ms	1.4 ms	×2.9
⚡	Simulation	`codegen_ascii_only[react.development.js]`	4.2 ms	1.5 ms	×2.9
⚡	Simulation	`codegen[App.tsx]`	23.6 ms	8.5 ms	×2.8
⚡	Simulation	`codegen_ascii_only[App.tsx]`	23.8 ms	8.7 ms	×2.7
⚡	Simulation	`codegen[kitchen-sink.tsx]`	49.1 ms	20.6 ms	×2.4
⚡	Simulation	`codegen_ascii_only[kitchen-sink.tsx]`	49.5 ms	21 ms	×2.4
⚡	Simulation	`codegen[RadixUIAdoptionSection.jsx]`	231.1 µs	147.7 µs	+56.54%
⚡	Simulation	`codegen_ascii_only[RadixUIAdoptionSection.jsx]`	234 µs	150.4 µs	+55.58%
🆕	Simulation	`codegen_ascii_only_sourcemap[App.tsx]`	N/A	23.8 ms	N/A
🆕	Simulation	`codegen_ascii_only_sourcemap[binder.ts]`	N/A	8.8 ms	N/A
🆕	Simulation	`codegen_ascii_only_sourcemap[kitchen-sink.tsx]`	N/A	49.5 ms	N/A
🆕	Simulation	`codegen_ascii_only_sourcemap[RadixUIAdoptionSection.jsx]`	N/A	234.8 µs	N/A
🆕	Simulation	`codegen_ascii_only_sourcemap[react.development.js]`	N/A	4.2 ms	N/A
🆕	Simulation	`codegen_sourcemap[App.tsx]`	N/A	23.6 ms	N/A
🆕	Simulation	`codegen_sourcemap[binder.ts]`	N/A	8.8 ms	N/A
🆕	Simulation	`codegen_sourcemap[kitchen-sink.tsx]`	N/A	49.1 ms	N/A
🆕	Simulation	`codegen_sourcemap[RadixUIAdoptionSection.jsx]`	N/A	232.1 µs	N/A
🆕	Simulation	`codegen_sourcemap[react.development.js]`	N/A	4.2 ms	N/A

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing c/09-10-test_codegen_benchmark_without_sourcemap (c77cd1e) with codex/codegen-ascii-only-benchmark (572cea4)}

9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3485f5c62

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

camc314 · 2026-09-10T16:38:27Z

+                let name = format!(
+                    "codegen{}{}",
+                    if ascii_only { "_ascii_only" } else { "" },
+                    if sourcemap_enabled { "_sourcemap" } else { "" }


this technically renamesthe benchmarks which means there's a massive diff in codspeed.

Maybe we have to clal this _no_sourcemap ?

camc314 mentioned this pull request Sep 10, 2026

test(codegen): benchmark ASCII-only output #26538

Open

camc314 assigned overlookmotel and Dunqing Sep 10, 2026

camc314 marked this pull request as ready for review September 10, 2026 16:26

Copilot AI lite review requested due to automatic review settings September 10, 2026 16:26

Copilot AI reviewed Sep 10, 2026

chatgpt-codex-connector Bot reviewed Sep 10, 2026

View reviewed changes

Comment thread tasks/benchmark/benches/codegen.rs Outdated

camc314 force-pushed the c/09-10-test_codegen_benchmark_without_sourcemap branch from 4e7bdc3 to c3485f5 Compare September 10, 2026 16:29

chatgpt-codex-connector Bot reviewed Sep 10, 2026

View reviewed changes

Comment thread tasks/benchmark/benches/codegen.rs Outdated

camc314 force-pushed the c/09-10-test_codegen_benchmark_without_sourcemap branch from c3485f5 to c52727e Compare September 10, 2026 16:33

test(codegen): benchmark without sourcemap

c77cd1e

camc314 force-pushed the c/09-10-test_codegen_benchmark_without_sourcemap branch from c52727e to c77cd1e Compare September 10, 2026 16:34

camc314 force-pushed the codex/codegen-ascii-only-benchmark branch from 5a10da4 to 572cea4 Compare September 10, 2026 16:35

camc314 commented Sep 10, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

test(codegen): benchmark without sourcemap - #26540

test(codegen): benchmark without sourcemap#26540
camc314 wants to merge 1 commit into
codex/codegen-ascii-only-benchmarkfrom
c/09-10-test_codegen_benchmark_without_sourcemap

camc314 commented Sep 10, 2026

Uh oh!

camc314 commented Sep 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector Bot commented Sep 10, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Sep 10, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

camc314 Sep 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

camc314 commented Sep 10, 2026

Uh oh!

camc314 commented Sep 10, 2026

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codspeed-hq Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by ×2.5

Performance Changes

Footnotes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

camc314 Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chatgpt-codex-connector Bot commented Sep 10, 2026 •

edited

Loading

codspeed-hq Bot commented Sep 10, 2026 •

edited

Loading