Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chore/bump react native version 0.80#232

Merged
patrickkabwe merged 7 commits into
mainfrom
chore/bump-react-native-version-0.80
Jul 1, 2025
Merged

Chore/bump react native version 0.80#232
patrickkabwe merged 7 commits into
mainfrom
chore/bump-react-native-version-0.80

Conversation

@patrickkabwe

@patrickkabwe patrickkabwe commented Jun 21, 2025

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features
    • Added a prompt to confirm overwriting existing module directories, preventing accidental data loss during module creation.
  • Chores
    • Updated React and React Native dependencies to their latest versions for improved compatibility and stability.
    • Improved native Android build configuration by enabling flexible page size support for better performance.
  • Refactor
    • Optimized file writing process by consolidating multiple configuration file writes into a single batch operation.
  • Tests
    • Added a clean build step in the Android build workflow to ensure fresh build outputs before assembling.

@patrickkabwe patrickkabwe self-assigned this Jun 21, 2025
@coderabbitai

coderabbitai Bot commented Jun 21, 2025

Copy link
Copy Markdown

Walkthrough

The changes update React and React Native package versions in the template's package.json, add an overwrite prompt and directory removal logic to the module creation CLI, refactor file writing in the Nitro package generator to batch writes and remove a redundant directory existence check, add a CMake argument to the Android Gradle build configuration, and include a clean build step in the Android CI workflow.

Changes

File(s) Change Summary
assets/template/package.json Bumped versions of "@types/react", "react", "react-native", "nitro-codegen", and "react-native-nitro-modules".
src/cli/create.ts Added logic to check for existing module directory, prompt user for overwrite, and remove directory if confirmed.
src/generate-nitro-package.ts Removed directory existence check and refactored file writes to batch operation in Nitro module creation process.
assets/template/android/build.gradle Added CMake argument -DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON in externalNativeBuild configuration.
.github/workflows/test-nitro-cli.yml Added "Clean and generate codegen artifacts" step running ./gradlew clean and codegen generation before Android build in CI workflow.

Suggested labels

released

Poem

Hop, hop, hop, the versions grow,
React and Native, onward they go!
A prompt appears, “Overwrite or not?”
The bunny checks, deletes the lot.
Batch writes now, swift as spring,
With every change, new joys we bring!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0058334 and ce44f8f.

📒 Files selected for processing (1)
  • assets/template/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • assets/template/package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Generate with yarn - view

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/test-nitro-cli.yml (1)

362-364: Consider caching Gradle artifacts for faster CI
Adding an actions/cache step for ~/.gradle/caches can significantly speed up subsequent Android builds.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 973d7c7 and d8e244c.

📒 Files selected for processing (1)
  • .github/workflows/test-nitro-cli.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (17)
  • GitHub Check: Test Android Build - yarn - module (Debug)
  • GitHub Check: Test Android Build - yarn - module (Release)
  • GitHub Check: Test Android Build - pnpm - view (Release)
  • GitHub Check: Test Android Build - yarn - view (Release)
  • GitHub Check: Test Android Build - yarn - view (Debug)
  • GitHub Check: Test Android Build - bun - view (Release)
  • GitHub Check: Test Android Build - bun - view (Debug)
  • GitHub Check: Test Android Build - pnpm - view (Debug)
  • GitHub Check: Test Android Build - pnpm - module (Release)
  • GitHub Check: Test Android Build - pnpm - module (Debug)
  • GitHub Check: Test Android Build - bun - module (Debug)
  • GitHub Check: Test Android Build - bun - module (Release)
  • GitHub Check: Test iOS Build - pnpm - module (Release)
  • GitHub Check: Test iOS Build - bun - view (Release)
  • GitHub Check: Test iOS Build - bun - view (Debug)
  • GitHub Check: Test iOS Build - yarn - module (Debug)
  • GitHub Check: Test iOS Build - bun - module (Debug)
🔇 Additional comments (1)
.github/workflows/test-nitro-cli.yml (1)

362-364: Properly clean the build directory before assembly
This new step ensures stale Gradle outputs are removed, which is critical after CMake argument changes.

@patrickkabwe

patrickkabwe commented Jun 22, 2025

Copy link
Copy Markdown
Owner Author

Currently the android build is failing when building a nitro view(Locally). this seem to be related to mrousavy/nitro#695. waiting for the next release of nitro

react-native-view/nitrogen/generated/android/kotlin/com/margelo/nitro/view/views/HybridHelloManager.kt:11:34 Cannot access 'class StateWrapperImpl : HybridClassBase, ReferenceStateWrapper': it is internal in file. FAILURE: Build failed with an exception. * What went wrong:
Execution failed for task ':react-native-view:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction > Compilation error. See log for more details * Try:

@patrickkabwe patrickkabwe merged commit 485c155 into main Jul 1, 2025
32 checks passed
@patrickkabwe patrickkabwe deleted the chore/bump-react-native-version-0.80 branch July 1, 2025 05:13
@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant