Chore/bump react native version 0.80#232
Conversation
WalkthroughThe changes update React and React Native package versions in the template's package.json, add an overwrite prompt and directory removal logic to the module creation CLI, refactor file writing in the Nitro package generator to batch writes and remove a redundant directory existence check, add a CMake argument to the Android Gradle build configuration, and include a clean build step in the Android CI workflow. Changes
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/test-nitro-cli.yml (1)
362-364: Consider caching Gradle artifacts for faster CI
Adding anactions/cachestep for~/.gradle/cachescan significantly speed up subsequent Android builds.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test-nitro-cli.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: Test Android Build - yarn - module (Debug)
- GitHub Check: Test Android Build - yarn - module (Release)
- GitHub Check: Test Android Build - pnpm - view (Release)
- GitHub Check: Test Android Build - yarn - view (Release)
- GitHub Check: Test Android Build - yarn - view (Debug)
- GitHub Check: Test Android Build - bun - view (Release)
- GitHub Check: Test Android Build - bun - view (Debug)
- GitHub Check: Test Android Build - pnpm - view (Debug)
- GitHub Check: Test Android Build - pnpm - module (Release)
- GitHub Check: Test Android Build - pnpm - module (Debug)
- GitHub Check: Test Android Build - bun - module (Debug)
- GitHub Check: Test Android Build - bun - module (Release)
- GitHub Check: Test iOS Build - pnpm - module (Release)
- GitHub Check: Test iOS Build - bun - view (Release)
- GitHub Check: Test iOS Build - bun - view (Debug)
- GitHub Check: Test iOS Build - yarn - module (Debug)
- GitHub Check: Test iOS Build - bun - module (Debug)
🔇 Additional comments (1)
.github/workflows/test-nitro-cli.yml (1)
362-364: Properly clean the build directory before assembly
This new step ensures stale Gradle outputs are removed, which is critical after CMake argument changes.
|
Currently the android build is failing when building a nitro view(Locally). this seem to be related to mrousavy/nitro#695. waiting for the next release of nitro react-native-view/nitrogen/generated/android/kotlin/com/margelo/nitro/view/views/HybridHelloManager.kt:11:34 Cannot access 'class StateWrapperImpl : HybridClassBase, ReferenceStateWrapper': it is internal in file. FAILURE: Build failed with an exception. * What went wrong:
Execution failed for task ':react-native-view:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction > Compilation error. See log for more details * Try: |
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by CodeRabbit