Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chore/update typescript#510

Merged
patrickkabwe merged 2 commits into
mainfrom
chore/update-typescript
Jul 7, 2026
Merged

Chore/update typescript#510
patrickkabwe merged 2 commits into
mainfrom
chore/update-typescript

Conversation

@patrickkabwe

@patrickkabwe patrickkabwe commented Jul 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Improved project creation so existing paths and monorepo package locations are handled more consistently.
    • Better support for modern TypeScript project setups and module resolution.
  • Chores
    • Updated TypeScript to a newer version across the project and templates.
    • Added Node.js type definitions to the compiler configuration.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4af41479-a26e-4a64-988d-33b9b230e357

📥 Commits

Reviewing files that changed from the base of the PR and between defd0af and 72bd754.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • assets/template/package.json
  • assets/template/tsconfig.json
  • package.json
  • src/cli/create.ts
  • tsconfig.json
📝 Walkthrough

Walkthrough

This PR upgrades the typescript devDependency to ^6.0.3 in both the root and template package.json files, updates moduleResolution to "bundler" in the template tsconfig and adds "types": ["node"] to the root tsconfig, and refactors createModule in src/cli/create.ts to compute and reuse a single resolvedTargetModulePath variable across path checks, directory removal, and instruction generation.

Changes

TypeScript upgrade and CLI path refactor

Layer / File(s) Summary
TypeScript version bump and tsconfig updates
package.json, assets/template/package.json, tsconfig.json, assets/template/tsconfig.json		 Bumps typescript to ^6.0.3 in root and template package.json, sets moduleResolution to "bundler" in template tsconfig, and adds "types": ["node"] in root tsconfig.
createModule target path resolution refactor
src/cli/create.ts		 Introduces resolvedTargetModulePath used consistently for NitroModuleFactory cwd, directory existence checks, CI error messages, directory removal, and generateInstructions module/package path computation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: updating TypeScript across the project.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-typescript

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/cli/create.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patrickkabwe patrickkabwe merged commit 417cb87 into main Jul 7, 2026
41 checks passed
@patrickkabwe patrickkabwe deleted the chore/update-typescript branch July 7, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@patrickkabwe