Codestin Search App

mcoker · 2023-09-12T22:26:59Z

This updates the __code element to use dir="ltr" so it will always be LTR. Everything else adapts to RTL as normal.

fixes #5927

patternfly-build · 2023-09-12T22:31:32Z

Preview: https://patternfly-pr-5928.surge.sh

A11y report: https://patternfly-pr-5928-a11y.surge.sh

thatblindgeye

Looks good, just a couple of comments:

I could see reasoning for allowing the header to be affected by RTL, and only making the __code element always kept LTR. Not a blocker as we can see what feedback we get if anything.
We could add a dir attribute to examples instead to avoid using CSS to dictate the direction, though with this we don't have to worry about consumers not doing so themselves for the HTML library (with React it could at least be hardcoded into the component). Not a blocker either.

mcoker · 2023-09-13T14:22:31Z

I could see reasoning for allowing the header to be affected by RTL, and only making the __code element always kept LTR. Not a blocker as we can see what feedback we get if anything.

I agree. That would certainly be simpler. For the sake of keeping it simple, if we don't have a strong preference one way or another, I'd be in favor of not trying to force LTR styling in the header. wdyt?

mcoker · 2023-09-13T15:53:09Z

We could add a dir attribute to examples instead to avoid using CSS to dictate the direction, though with this we don't have to worry about consumers not doing so themselves for the HTML library (with React it could at least be hardcoded into the component). Not a blocker either.

Agree - when I created the LTR/RTL classes, I wasn't keeping in mind that you can apply dir to elements in the page. It seems like in most cases, dir should be used. The only downside is that if we use the dir attribute (markup change) is that if we change that value, react users should be good since we can update the react component, but core users won't get the change without a markup change - so we need to continue to support the previous dir value for core users, otherwise it may be a breaking change.

thatblindgeye · 2023-09-13T17:50:49Z

I'd be in favor of not trying to force LTR styling in the header. wdyt?

I'd be good with that!

And good point re: the dir attribute. I think the styling vs markup topic happened before with RTL (though maybe briefly?), but either way using the styling here isn't a blocker for me.

srambach

!tcefreP

patternfly-build · 2023-09-13T21:08:31Z

🎉 This PR is included in version 5.1.0-prerelease.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

* chore(select): fixed text in HTML example to show multiple checks can be selected (#5663) * chore: Update release.yml to node 18 [ci skip] * chore: add superclean npm script (#5798) * chore(options-menu): updated markup to match react component (#5809) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.3 (#5720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (#5756) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updated use of flex start/end to be more compatible (#5807) * fix(chip): add margin for badge when used in text element (#5844) * feat(global): added RTL support (#5778) * fix: added tree view icon (#5845) * fix: added tree view icon * chore: put treeviewicon in alphabetical order * chore: rtl fixes, screenshots (#5854) * chore: rtl fixes, screenshots * chore: checkin screenshots * chore(deps): update dependency @patternfly/documentation-framework to v5.1.7 (#5852) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: enable RTL switcher on full page examples (#5859) * docs: update location of and references to docs to consolidate and organize information. (#5773) * fix: added base, wizard, pagination RTL styles (#5860) * chore(Accordion,ExpandableSection): added more RTL styling (#5861) * fix(RTL): refactor mixins, add slider rtl styles (#5867) * fix(nav): added optional text wrapper for nav text (#5868) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.9 (#5863) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Toolbar): updated toolbar pagination structure (#5862) * fix(breadcrumb): added rtl support (#5870) * chore(card): updated horiz demo image (#5875) * chore(Alert,NotificationDrawer): added additional rtl styling (#5866) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.10 (#5880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Nav, Menu): apply RTL fixes (#5873) * fix(clipboard-copy): added rtl styles (#5876) * fix(page): added rtl styles (#5878) * fix(calendar-month): rtl support (#5869) * chore(Card,Tile): apply RTL fixes (#5881) * fix: added tabs and jump links rtl styles (#5877) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.11 (#5885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(DataList): added additional rtl styling (#5871) * chore(DataList): added additional rtl styling * Add comment to update notif badge in breaking change * fix(popover, tooltip): added rtl styles (#5882) * fix(tree-view): added rtl styles (#5883) * chore(Table): added additional RTL styling (#5887) * chore(Drawer): transforms and shadows on RTL drawer (#5888) * fix(forms): updated rtl styles (#5889) * fix(skeleton): added rtl styles (#5891) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.12 (#5894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(slider): added root decl for var to create react token (#5895) * chore(ModalBox): center modal for workspace in RTL (#5893) * fix(rtl): fixes truncate rtl (#5874) * fix(ModalBox): fix centering on mobile (#5905) * chore: added backstop as dev dependency, update config (#5904) * chore(popover): center examples (#5906) * fix(nav): updated example css (#5903) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.14 (#5909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: remove workspace RTL classes (#5912) * chore: update screenshots (#5915) * fix: Update upload-preview.js to use new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.1.15 (#5916) * chore(deps): update dependency @patternfly/react-table to v5.0.1 (#5914) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.0.1 (#5910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-core to v5.0.1 (#5913) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: mirror fa-sort icon (#5920) * fix: mirror bg image position in rtl (#5922) * fix(progress): updated indicator direction (#5923) * chore: update readme to reference new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.2.0 (#5925) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(code-editor): make code box and header LTR (#5928) * fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block * fix(banner): fixed invalid dark theme color declaration (#5933) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.2 (#5934) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.3 (#5940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(clipboard-copy): add code example with rtl support (#5941) * fix(card): removed border from clickable/selectable selected (#5935) * feat(Button): extended inline styling (#5696) * fix(menu): updated drilldown breadcrumb menu icons to work in RTL (#5924) * fix(toolbar): fix expand all icon in RTL (#5937) * chore(toolbar): mirror expand all icon in rtl * chore: update * chore: use icon shouldMirrorRTL param * fix(popover/tooltip): revert arrow logical prop positioning (#5952) * fix(popover/tooltip): revert arrow logical prop positioning * chore: add missing local css import * chore(screenshots): updated full page screenshots (#5960) * chore(deps): update dependency @patternfly/react-core to v5.1.1 (#5975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps-dev): bump postcss from 8.4.27 to 8.4.31 (#5971) * chore(Toolbar): increase workspace container height (#5962) * chore(screenshots): update visual regression screenshots (#5959) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.17 (#5961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.1 (#5977) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.1 (#5974) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(check-radio): added aria-describedby to check/radio (#5969) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.18 (#5982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(brand/card): update examples to display logo in dark theme (#5681) * fix(input): standardized check and radio alignment (#5947) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.19 (#5985) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.20 (#5994) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump @babel/traverse from 7.22.15 to 7.23.2 (#6001) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.15 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Switch): updated focus style to focus-visible (#5995) * chore(menu-toggle): updated demos to use menu-toggle (#5782) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.24 (#6014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(Accordion): added left-aligned toggle variant (#5987) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.26 (#6020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: V6 merge main.10.30 (#6023) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.0 (#6027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): reverts to pre-v6 merge (#6038) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.1 (#6040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(globals): update invalid selector in global css (#6044) * feat(breaker): bump this version to 6.0 (#5800) BREAKING CHANGE: 6.0.0-alpha.0 * fix: white space change to kick off dry run * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (#5843) * feat(Button): adds tokens and applies to buttons (#5908) * feat(table): apply tokens from hackathon (#5965) * feat(menu-toggle): add in work from hackathon (#5931) * feat(nav): adds tokens to page and nav (#5942) * chore(tokens): update tokens from figma (#5970) * feat(page): page and masthead updates from hackathon (#5968) * chore(v6): merge main into v6 (#5981) * fix(tokens): add dark theme blend mode token (#5992) * feat(notificationBadge): refactor with tokens (#5991) * chore(masthead ): applied tokens (#6004) * feat(alert): apply tokens (#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (#6025) * fix(box-shadow): typo in box shadow token names (#6039) * fix(badge): adds tokens, dropdown toggle icon (#6037) * feat(hint): apply tokens (#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ashley Ray <[email protected]> Co-authored-by: Nicole Thoen <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Sarah Rambacher <[email protected]> Co-authored-by: Matt Nolting <[email protected]> Co-authored-by: Jenny <[email protected]>

* fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block

* chore(select): fixed text in HTML example to show multiple checks can be selected (patternfly#5663) * chore: Update release.yml to node 18 [ci skip] * chore: add superclean npm script (patternfly#5798) * chore(options-menu): updated markup to match react component (patternfly#5809) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.3 (patternfly#5720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (patternfly#5756) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updated use of flex start/end to be more compatible (patternfly#5807) * fix(chip): add margin for badge when used in text element (patternfly#5844) * feat(global): added RTL support (patternfly#5778) * fix: added tree view icon (patternfly#5845) * fix: added tree view icon * chore: put treeviewicon in alphabetical order * chore: rtl fixes, screenshots (patternfly#5854) * chore: rtl fixes, screenshots * chore: checkin screenshots * chore(deps): update dependency @patternfly/documentation-framework to v5.1.7 (patternfly#5852) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: enable RTL switcher on full page examples (patternfly#5859) * docs: update location of and references to docs to consolidate and organize information. (patternfly#5773) * fix: added base, wizard, pagination RTL styles (patternfly#5860) * chore(Accordion,ExpandableSection): added more RTL styling (patternfly#5861) * fix(RTL): refactor mixins, add slider rtl styles (patternfly#5867) * fix(nav): added optional text wrapper for nav text (patternfly#5868) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.9 (patternfly#5863) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Toolbar): updated toolbar pagination structure (patternfly#5862) * fix(breadcrumb): added rtl support (patternfly#5870) * chore(card): updated horiz demo image (patternfly#5875) * chore(Alert,NotificationDrawer): added additional rtl styling (patternfly#5866) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.10 (patternfly#5880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Nav, Menu): apply RTL fixes (patternfly#5873) * fix(clipboard-copy): added rtl styles (patternfly#5876) * fix(page): added rtl styles (patternfly#5878) * fix(calendar-month): rtl support (patternfly#5869) * chore(Card,Tile): apply RTL fixes (patternfly#5881) * fix: added tabs and jump links rtl styles (patternfly#5877) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.11 (patternfly#5885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(DataList): added additional rtl styling (patternfly#5871) * chore(DataList): added additional rtl styling * Add comment to update notif badge in breaking change * fix(popover, tooltip): added rtl styles (patternfly#5882) * fix(tree-view): added rtl styles (patternfly#5883) * chore(Table): added additional RTL styling (patternfly#5887) * chore(Drawer): transforms and shadows on RTL drawer (patternfly#5888) * fix(forms): updated rtl styles (patternfly#5889) * fix(skeleton): added rtl styles (patternfly#5891) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.12 (patternfly#5894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(slider): added root decl for var to create react token (patternfly#5895) * chore(ModalBox): center modal for workspace in RTL (patternfly#5893) * fix(rtl): fixes truncate rtl (patternfly#5874) * fix(ModalBox): fix centering on mobile (patternfly#5905) * chore: added backstop as dev dependency, update config (patternfly#5904) * chore(popover): center examples (patternfly#5906) * fix(nav): updated example css (patternfly#5903) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.14 (patternfly#5909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: remove workspace RTL classes (patternfly#5912) * chore: update screenshots (patternfly#5915) * fix: Update upload-preview.js to use new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.1.15 (patternfly#5916) * chore(deps): update dependency @patternfly/react-table to v5.0.1 (patternfly#5914) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.0.1 (patternfly#5910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-core to v5.0.1 (patternfly#5913) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: mirror fa-sort icon (patternfly#5920) * fix: mirror bg image position in rtl (patternfly#5922) * fix(progress): updated indicator direction (patternfly#5923) * chore: update readme to reference new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.2.0 (patternfly#5925) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(code-editor): make code box and header LTR (patternfly#5928) * fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block * fix(banner): fixed invalid dark theme color declaration (patternfly#5933) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.2 (patternfly#5934) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.3 (patternfly#5940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(clipboard-copy): add code example with rtl support (patternfly#5941) * fix(card): removed border from clickable/selectable selected (patternfly#5935) * feat(Button): extended inline styling (patternfly#5696) * fix(menu): updated drilldown breadcrumb menu icons to work in RTL (patternfly#5924) * fix(toolbar): fix expand all icon in RTL (patternfly#5937) * chore(toolbar): mirror expand all icon in rtl * chore: update * chore: use icon shouldMirrorRTL param * fix(popover/tooltip): revert arrow logical prop positioning (patternfly#5952) * fix(popover/tooltip): revert arrow logical prop positioning * chore: add missing local css import * chore(screenshots): updated full page screenshots (patternfly#5960) * chore(deps): update dependency @patternfly/react-core to v5.1.1 (patternfly#5975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps-dev): bump postcss from 8.4.27 to 8.4.31 (patternfly#5971) * chore(Toolbar): increase workspace container height (patternfly#5962) * chore(screenshots): update visual regression screenshots (patternfly#5959) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.17 (patternfly#5961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.1 (patternfly#5977) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.1 (patternfly#5974) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(check-radio): added aria-describedby to check/radio (patternfly#5969) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.18 (patternfly#5982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(brand/card): update examples to display logo in dark theme (patternfly#5681) * fix(input): standardized check and radio alignment (patternfly#5947) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.19 (patternfly#5985) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.20 (patternfly#5994) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump @babel/traverse from 7.22.15 to 7.23.2 (patternfly#6001) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.15 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Switch): updated focus style to focus-visible (patternfly#5995) * chore(menu-toggle): updated demos to use menu-toggle (patternfly#5782) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.24 (patternfly#6014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(Accordion): added left-aligned toggle variant (patternfly#5987) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.26 (patternfly#6020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: V6 merge main.10.30 (patternfly#6023) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.0 (patternfly#6027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): reverts to pre-v6 merge (patternfly#6038) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.1 (patternfly#6040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(globals): update invalid selector in global css (patternfly#6044) * feat(breaker): bump this version to 6.0 (patternfly#5800) BREAKING CHANGE: 6.0.0-alpha.0 * fix: white space change to kick off dry run * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (patternfly#5843) * feat(Button): adds tokens and applies to buttons (patternfly#5908) * feat(table): apply tokens from hackathon (patternfly#5965) * feat(menu-toggle): add in work from hackathon (patternfly#5931) * feat(nav): adds tokens to page and nav (patternfly#5942) * chore(tokens): update tokens from figma (patternfly#5970) * feat(page): page and masthead updates from hackathon (patternfly#5968) * chore(v6): merge main into v6 (patternfly#5981) * fix(tokens): add dark theme blend mode token (patternfly#5992) * feat(notificationBadge): refactor with tokens (patternfly#5991) * chore(masthead ): applied tokens (patternfly#6004) * feat(alert): apply tokens (patternfly#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (patternfly#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (patternfly#6025) * fix(box-shadow): typo in box shadow token names (patternfly#6039) * fix(badge): adds tokens, dropdown toggle icon (patternfly#6037) * feat(hint): apply tokens (patternfly#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ashley Ray <[email protected]> Co-authored-by: Nicole Thoen <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Sarah Rambacher <[email protected]> Co-authored-by: Matt Nolting <[email protected]> Co-authored-by: Jenny <[email protected]>

fix(code-editor): make code box and header LTR

005a68c

mcoker requested review from mattnolting, srambach, thatblindgeye, tlabaj and wise-king-sullyman September 12, 2023 22:26

wise-king-sullyman approved these changes Sep 12, 2023

View reviewed changes

thatblindgeye approved these changes Sep 13, 2023

View reviewed changes

tlabaj approved these changes Sep 13, 2023

View reviewed changes

chore: refactor to use dir instead of css for ltr on code block

16818a5

mcoker requested a review from thatblindgeye September 13, 2023 18:51

thatblindgeye approved these changes Sep 13, 2023

View reviewed changes

srambach approved these changes Sep 13, 2023

View reviewed changes

srambach merged commit c2db122 into patternfly:main Sep 13, 2023

patternfly-build added the released on @prerelease label Sep 13, 2023

mcoker mentioned this pull request Sep 14, 2023

Code editor - make the code area LTR patternfly/patternfly-react#9625

Closed

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023

fix(code-editor): make code box and header LTR (patternfly#5928)

afdbe69

* fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block

mcoker deleted the issue-5927 branch January 7, 2025 16:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(code-editor): make code box and header LTR#5928

fix(code-editor): make code box and header LTR#5928
srambach merged 2 commits intopatternfly:mainfrom
mcoker:issue-5927

mcoker commented Sep 12, 2023 •

edited

Loading

Uh oh!

patternfly-build commented Sep 12, 2023 •

edited

Loading

Uh oh!

thatblindgeye left a comment

Uh oh!

mcoker commented Sep 13, 2023

Uh oh!

mcoker commented Sep 13, 2023

Uh oh!

thatblindgeye commented Sep 13, 2023

Uh oh!

srambach left a comment

Uh oh!

patternfly-build commented Sep 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mcoker commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patternfly-build commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thatblindgeye left a comment

Choose a reason for hiding this comment

Uh oh!

mcoker commented Sep 13, 2023

Uh oh!

mcoker commented Sep 13, 2023

Uh oh!

thatblindgeye commented Sep 13, 2023

Uh oh!

srambach left a comment

Choose a reason for hiding this comment

Uh oh!

patternfly-build commented Sep 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mcoker commented Sep 12, 2023 •

edited

Loading

patternfly-build commented Sep 12, 2023 •

edited

Loading