PG-1607 Fix tests and documentation around Vault TLS support #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.48%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #396 +/- ##
=====================================================
+ Coverage 85.40% 85.48% +0.08%
=====================================================
Files 22 22
Lines 2535 2536 +1
Branches 385 387 +2
=====================================================
+ Hits 2165 2168 +3
+ Misses 296 294 -2
Partials 74 74
🚀 New features to boost your workflow:
|
5bcbc16 to
6128dcf
Compare
Andriciuc
approved these changes
Jun 5, 2025
dAdAbird
approved these changes
Jun 5, 2025
…e_key_provider Also do not rely on the Vault server setup since any file on disk will do.
This is a very basic test but before this there were no tests at all.
Since the dev mode of Vault supports generating HTTPs ceritficates we should just use that since in production everyone will use HTTPS we should run our tests with HTTPS too.
We should encourage HTTPS over HTTP in out examples.
6128dcf to
94677a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split out from #392 since the refactoring to use TLS by default in both documentation and tests is largely unrelated to the behavioral changes I proposed there.
This makes sure we run TLS in our test suite since that is what we will use by default anyway plus also push for TLS in our documentation.