Updated architecture/index.md based on AA feedback #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the Architecture topic with the following: - New intro detailing the long term tde goals in a paragraph - Updated the ## Typical setup scenarios topic with better writing and improved flow - Added note to WAL Encryption that it is not to be used in prod env - General small fixes to paragraphs, wrongly written words and such
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-17.5.2 #439 +/- ##
=================================================
Coverage ? 84.68%
=================================================
Files ? 21
Lines ? 2593
Branches ? 401
=================================================
Hits ? 2196
Misses ? 316
Partials ? 81
🚀 New features to boost your workflow:
|
dutow
reviewed
Jun 18, 2025
* reworded intro paragraphs for better flow * Improved headings and some paragraphs throughout the file to be present tense * improved Add providers with link to parameter and paragraph flow * Reworded Simple "one principal key" encryption step 5 and note and id the same for Complete multi-tenancy
|
Updated the Architecture topic with the following:
|
Removed "and `pg_tde.wal_encrypt`"
removed unneeded note These functions do not verify the parameters. To verify them, see [`pg_tde_verify_key`](../functions.md#pg_tde_verify_key). added note for `pg_tde_change_key_provider` command line tool deleted unneeded paragraph removed WAL for ## Typical setup scenarios ### Simple "one principal key" encryption removed typical setup scenarios as they are outdated and confuse the users
Andriciuc
commented
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Architecture topic with the following: