Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow initialization of the context at instantiation #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonasbn merged 1 commit into from
Oct 12, 2021
Merged

Allow initialization of the context at instantiation #171

jonasbn merged 1 commit into from
Oct 12, 2021

Conversation

@ehuelsmann
Copy link
Member

@ehuelsmann ehuelsmann commented Oct 4, 2021

Description

This allows for much cleaner context creation to seed the context
of a newly created workflow.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ehuelsmann
Allow initialization of the context at instantiation
edf6d28 
This allows for much cleaner context creation to seed the context
of a newly created workflow.
@ehuelsmann ehuelsmann requested a review from jonasbn October 4, 2021 22:04
@coveralls
Copy link

coveralls commented Oct 4, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 92.158% when pulling edf6d28 on ehuelsmann:more-1.x-initialized-context into f317382 on jonasbn:master.

@ehuelsmann ehuelsmann mentioned this pull request Oct 9, 2021
Merged
6 tasks
jonasbn
jonasbn approved these changes Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonasbn jonasbn merged commit c65472b into perl-workflow:master Oct 12, 2021
@jonasbn jonasbn added this to the 2.0 milestone Oct 12, 2021
@ehuelsmann ehuelsmann deleted the more-1.x-initialized-context branch October 12, 2021 05:11
ehuelsmann added a commit that referenced this pull request Oct 12, 2021
@ehuelsmann
Allow initialization of the context at instantiation (#171)
c075183 
This allows for much cleaner context creation to seed the context
of a newly created workflow.
@jonasbn jonasbn modified the milestones: 2.0, 1.57 Oct 17, 2021
@jonasbn
Copy link
Collaborator

jonasbn commented Oct 17, 2021 •
edited
Loading

Moved to milestone 1.57 from 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasbn jonasbn jonasbn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.57

Development

Successfully merging this pull request may close these issues.

3 participants

@ehuelsmann @coveralls @jonasbn