-
Notifications
You must be signed in to change notification settings - Fork 11
Fix #172: Call the correct method name for autorun INITIAL states #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jonasbn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
The build fails on an issue with Syntax::Keyword::Try version 0.25. See also active issues: rt.cpan.org |
|
I do not think this is an issue as such, but we might want to stick to 0.24 or make sure if the toolchain works, there is some suggestion that the issue originates from other dependencies and is fixed in XS::Parse::Keyword 0.10 REF: RT: 136860 |
The issue is known with the author and I'm working with him on a fixed version of XS::Parse::Keyword::Builder, which is the cause of the installation problem (contacted him last night about it). The likely solution is to change some C conditional in the XS::* sources. |
|
Question: are the fixes for XS::* a prerequisite for this PR? (Taking into account that we already depend on it in master?) |
|
https://github.com/ehuelsmann/perl-workflow/actions/runs/1325708094 shows that the build failure on this PR is a problem in the test suite for XS::* by adding --notest to the cpanm invocations (ehuelsmann@1d71481) |
|
I think we are good |
|
Thanks for merging! There's some discussion left before we can go to 2.0, but i would really like to have this fix. Do you think we should do 1.57? |
|
Moved to milestone 1.57 from 2.00 |
Description
Fixes/addresses (If applicable) #171
Type of change
Please delete options that are not relevant.
Checklist: