Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ehuelsmann
Copy link
Member

Description

Fixes/addresses (If applicable) #171

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ehuelsmann ehuelsmann requested a review from jonasbn October 9, 2021 20:05
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.211% when pulling eebe1c1 on ehuelsmann:1.x-autorun-initial into f317382 on jonasbn:master.

Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonasbn
Copy link
Collaborator

jonasbn commented Oct 10, 2021

The build fails on an issue with Syntax::Keyword::Try version 0.25.

See also active issues: rt.cpan.org

@jonasbn
Copy link
Collaborator

jonasbn commented Oct 10, 2021

I do not think this is an issue as such, but we might want to stick to 0.24 or make sure if the toolchain works, there is some suggestion that the issue originates from other dependencies and is fixed in XS::Parse::Keyword 0.10

REF: RT: 136860

@ehuelsmann
Copy link
Member Author

I do not think this is an issue as such, but we might want to stick to 0.24 or make sure if the toolchain works, there is some suggestion that the issue originates from other dependencies and is fixed in XS::Parse::Keyword 0.10

REF: RT: 136860

The issue is known with the author and I'm working with him on a fixed version of XS::Parse::Keyword::Builder, which is the cause of the installation problem (contacted him last night about it). The likely solution is to change some C conditional in the XS::* sources.

@ehuelsmann
Copy link
Member Author

Question: are the fixes for XS::* a prerequisite for this PR? (Taking into account that we already depend on it in master?)

@ehuelsmann
Copy link
Member Author

https://github.com/ehuelsmann/perl-workflow/actions/runs/1325708094 shows that the build failure on this PR is a problem in the test suite for XS::* by adding --notest to the cpanm invocations (ehuelsmann@1d71481)

@jonasbn
Copy link
Collaborator

jonasbn commented Oct 12, 2021

I think we are good

@jonasbn jonasbn merged commit 99f5052 into perl-workflow:master Oct 12, 2021
@jonasbn jonasbn added this to the 2.0 milestone Oct 12, 2021
@ehuelsmann ehuelsmann deleted the 1.x-autorun-initial branch October 12, 2021 05:08
@ehuelsmann
Copy link
Member Author

Thanks for merging! There's some discussion left before we can go to 2.0, but i would really like to have this fix. Do you think we should do 1.57?

@jonasbn jonasbn modified the milestones: 2.0, 1.57 Oct 17, 2021
@jonasbn jonasbn linked an issue Oct 17, 2021 that may be closed by this pull request
@jonasbn
Copy link
Collaborator

jonasbn commented Oct 17, 2021

Moved to milestone 1.57 from 2.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autorun INITIAL state throws an error

3 participants