Feat: Enable embedding of datadocs #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darapuk
commented
Feb 19, 2022
querybook/webapp/components/EnvironmentAppSidebar/EnvironmentAppSidebar.tsx
Outdated
Show resolved
Hide resolved
darapuk
commented
Feb 19, 2022
querybook/webapp/components/EnvironmentAppRouter/EnvironmentModalSwitchRouter.tsx
Outdated
Show resolved
Hide resolved
czgu
requested changes
Feb 22, 2022
querybook/webapp/components/EnvironmentAppRouter/EnvironmentModalSwitchRouter.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/components/EnvironmentAppSidebar/EnvironmentAppSidebar.tsx
Outdated
Show resolved
Hide resolved
1. Cleanup embedded_datadoc URL 2. Cleanup datadoc title re-write
|
|
czgu
approved these changes
Mar 15, 2022
|
Could I get one more review of this @czgu? |
czgu
reviewed
Mar 16, 2022
czgu
approved these changes
Mar 16, 2022
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Feb 28, 2023
* Add endpoint for embeddable DataDocs * remove CSS * CSS is used to enable scrolling * remove un-needed params * remove unneeded CSS * lint * add type hints * PR feedback 1. Cleanup embedded_datadoc URL 2. Cleanup datadoc title re-write * lint * cleanup collapsing logic & Add story * lint * refactor to remove embedding from AppSidebar to envCollapsed reducer * lint * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This PR exposes an endpoint to enable embedding of DataDocs in external Applications. One such use case will be the ability to search and discover DataDocs through the open source project Datahub.
It is not certain that this is the method that we will employ to fully embed the DataDocs, but wanted to open up this workflow for the Querybook community if it would be useful.
External Dependencies:
Metadata modeling to ingest DataDocs to Datahub: https://datahubspace.slack.com/archives/C02R2NBJXD1/p1645047031441309
Requirements: